Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-285: [Dev] Remove wrong or unnecessary workflow files from arrow-site #303

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 23, 2023

As discussed on #285 currently we don't check the PR titles nor use the merge script.
We could implement some PR checker but if we take a look on the Closed PRs almost none of them are following the structure and we don't seem to use the merge script at all and always use the merge button.

At this point I would propose to just remove this files.

Closes #285

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you ask INFRA to change the default merge message to "Pull request title and description" before we merge this?
See also: https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/

@raulcd
Copy link
Member Author

raulcd commented Jan 24, 2023

Could you ask INFRA to change the default merge message to "Pull request title and description" before we merge this?

Requested here: https://issues.apache.org/jira/browse/INFRA-24122

@jorisvandenbossche jorisvandenbossche merged commit e7a7fc2 into apache:master Jan 24, 2023
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jan 24, 2023

Thanks!

(the setting is already applied)

@raulcd raulcd deleted the GH-285 branch January 24, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Update the merge_pr script to work with GitHub issues
3 participants