Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Arrow] Add benchmarks for the round functions. #15200

Closed
EpsilonPrime opened this issue Jan 5, 2023 · 0 comments · Fixed by #15201
Closed

[C++][Arrow] Add benchmarks for the round functions. #15200

EpsilonPrime opened this issue Jan 5, 2023 · 0 comments · Fixed by #15201
Assignees
@EpsilonPrime
Labels
Component: Benchmarking Component: C++ Type: enhancement
Milestone
11.0.0

Comments

@EpsilonPrime
Copy link
Contributor

Describe the enhancement requested

Benchmarks for these functions will help prevent regressions to these kernel functions when future changes occur.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Jan 5, 2023
Merged
cyb70289 pushed a commit that referenced this issue Jan 10, 2023
@EpsilonPrime @wjones127
GH-15200: [C++] Created benchmarks for round kernels. (#15201)
85b167c 
The four existing kernel functions Ceil, Floor, Round, and Trunc gain benchmarks with this change.
* Closes: #15200

Lead-authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
@cyb70289 cyb70289 added this to the 11.0.0 milestone Jan 10, 2023
EpsilonPrime added a commit to EpsilonPrime/arrow that referenced this issue Jan 10, 2023
@EpsilonPrime @wjones127
apacheGH-15200: [C++] Created benchmarks for round kernels. (apache#1…
fac1f48 
…5201)

The four existing kernel functions Ceil, Floor, Round, and Trunc gain benchmarks with this change.
* Closes: apache#15200

Lead-authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
EpsilonPrime added a commit to EpsilonPrime/arrow that referenced this issue Jan 10, 2023
@EpsilonPrime @wjones127
apacheGH-15200: [C++] Created benchmarks for round kernels. (apache#1…
e8e977b 
…5201)

The four existing kernel functions Ceil, Floor, Round, and Trunc gain benchmarks with this change.
* Closes: apache#15200

Lead-authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
This was referenced Jan 11, 2023
Closed
Merged
@github-actions github-actions bot mentioned this issue Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EpsilonPrime EpsilonPrime

Labels
Component: Benchmarking Component: C++ Type: enhancement
Projects
None yet
Milestone
11.0.0
3 participants
@rok @EpsilonPrime @cyb70289