-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-15200: [C++] Created benchmarks for round kernels. #15201
Conversation
|
|
One thought about the number of benchmarks -- there is a benchmark for every type and round mode (10 each). Some alternatives could be to try to fold the round mode tests into the type (for less visibility) or come up with a "less frequently used" benchmark concept if having less benchmarks is ideal. |
It does looks too many benchmarks are generated. And I guess most of them are similar. |
Do you plan to add benchmark for decimal types? It can be in a followup PR. |
Done. |
All of the tests together are about 3 minutes. I've selected 3 of the round modes to run normally and disabled the rest using a command line flag. |
Add labels for size and inverse_null_proportion arguments as suggested by wjones127. Co-authored-by: Will Jones <willjones127@gmail.com>
…ithmetic benchmarks which round was derived from.
I've updated the arithmetic benchmarks to also have labels. Thanks for the suggestion! |
…ts as they will require a much larger change (and should encompass the rest of the benchmarks in this directory which also do not have DECIMAL tests).
Travis CI error is not related. |
Not related to this PR, but the benchmark result is not obvious to me.
|
Benchmark runs are scheduled for baseline = 33d677c and contender = 85b167c. 85b167c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…5201) The four existing kernel functions Ceil, Floor, Round, and Trunc gain benchmarks with this change. * Closes: apache#15200 Lead-authored-by: David Sisson <EpsilonPrime@users.noreply.github.com> Co-authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
…5201) The four existing kernel functions Ceil, Floor, Round, and Trunc gain benchmarks with this change. * Closes: apache#15200 Lead-authored-by: David Sisson <EpsilonPrime@users.noreply.github.com> Co-authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
The four existing kernel functions Ceil, Floor, Round, and Trunc gain benchmarks with this change.