Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Set minimal permissions on pr_review_trigger.yml #35706

Closed
diogoteles08 opened this issue May 22, 2023 · 0 comments · Fixed by #35708
Closed

[CI] Set minimal permissions on pr_review_trigger.yml #35706

diogoteles08 opened this issue May 22, 2023 · 0 comments · Fixed by #35708

Comments

@diogoteles08
Copy link
Contributor

Describe the enhancement requested

Hi!

I'm here to suggest that you set minimal permissions to your workflow pr_review_trigget.yml, because currently it doesn't specify the permissions for its jobs and their privileges are being determined by GitHub's defaults. I noticed that all of your other workflows already have the permissions defined, so I'll assume you already know the security benefits involved =)

If you have a reason not to define the permissions on that specific workflow, let me know! Otherwise I'll already raise a PR to add them and close this issue, as it's a very simple change.

Context

I'm Diogo and I work on Google's Open Source Security Team(GOSST) in cooperation with the Open Source Security Foundation (OpenSSF). My core job is to suggest and implement security changes on widely used open source projects 😊

Component(s)

Continuous Integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants