Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35706: [CI] Set minimal permissions on pr_review_trigger.yml #35708

Merged

Conversation

diogoteles08
Copy link
Contributor

@diogoteles08 diogoteles08 commented May 22, 2023

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35706 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label May 22, 2023
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, while pr_review is a restricted trigger (well for fork PRs which is all PRs for us) it makes sense to keep this consistent with the other workflows.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 24, 2023
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 24, 2023
@raulcd raulcd merged commit c4ea194 into apache:main May 24, 2023
@ursabot
Copy link

ursabot commented May 30, 2023

Benchmark runs are scheduled for baseline = dcdeab7 and contender = c4ea194. c4ea194 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed ⬇️2.6% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.18% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c4ea194c ec2-t3-xlarge-us-east-2
[Failed] c4ea194c test-mac-arm
[Finished] c4ea194c ursa-i9-9960x
[Failed] c4ea194c ursa-thinkcentre-m75q
[Finished] dcdeab76 ec2-t3-xlarge-us-east-2
[Finished] dcdeab76 test-mac-arm
[Failed] dcdeab76 ursa-i9-9960x
[Finished] dcdeab76 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 31, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Set minimal permissions on pr_review_trigger.yml
4 participants