Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Writer helper methods need to be applied to PromotableWriters #38614

Closed
jduo opened this issue Nov 6, 2023 · 1 comment · Fixed by #38631
Closed

[Java] Writer helper methods need to be applied to PromotableWriters #38614

jduo opened this issue Nov 6, 2023 · 1 comment · Fixed by #38631
Assignees
@jduo
Labels
Component: Java Type: bug
Milestone
15.0.0

Comments

@jduo
Copy link
Member

jduo commented Nov 6, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The new writer methods add in #37883 and #37791 need to be added to the PromotableWriter classes.

Additionally the writeToVarBinary and related methods should be renamed to writeVarBinary for consistency.

Component(s)

Java
@jduo jduo added the Type: bug label Nov 6, 2023
@jduo
Copy link
Member Author

jduo commented Nov 6, 2023

take

jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 7, 2023
@jduo
apacheGH-38614: [Java] Rename binary writer helper methods
27dfd54 
Rename from writeTo$type to write$type for consistency with other methods
@github-actions github-actions bot mentioned this issue Nov 7, 2023
Merged
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 9, 2023
@jduo
apacheGH-38614: [Java] Add writer helper methods to more writer classes
4ad9fe9 
- Rename from writeTo$type to write$type for consistency with other methods
- Add new helper methods to PromotableWriter
- Add new helper methods to complex writers such as list and union
lidavidm pushed a commit that referenced this issue Nov 9, 2023
@jduo
GH-38614: [Java] Add VarBinary and VarCharWriter helper methods to mo…
0acf4c8 
…re writers (#38631)

### Rationale for this change
Add the overrides for new convenience Writer methods added to VarCharWriter and VarBinaryWriter so that classes that
use composition such as UnionWriter and PromotableWriter can invoke them properly.

### What changes are included in this PR?
- Rename from writeTo$type to write$type for consistency with other methods
- Add new helper methods to PromotableWriter
- Add new helper methods to complex writers such as list and union

### Are these changes tested?
Yes. New unit tests added for several Writer classes.

 **This PR includes breaking changes to public APIs.** 
The writeTo<Type>() and similar methods in Writers have been renamed to just write<Type>()

* Closes: #38614

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 15.0.0 milestone Nov 9, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@jduo @loicalleyne
apacheGH-38614: [Java] Add VarBinary and VarCharWriter helper methods…
dd08671 
… to more writers (apache#38631)

### Rationale for this change
Add the overrides for new convenience Writer methods added to VarCharWriter and VarBinaryWriter so that classes that
use composition such as UnionWriter and PromotableWriter can invoke them properly.

### What changes are included in this PR?
- Rename from writeTo$type to write$type for consistency with other methods
- Add new helper methods to PromotableWriter
- Add new helper methods to complex writers such as list and union

### Are these changes tested?
Yes. New unit tests added for several Writer classes.

 **This PR includes breaking changes to public APIs.** 
The writeTo<Type>() and similar methods in Writers have been renamed to just write<Type>()

* Closes: apache#38614

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@tokoko tokoko mentioned this issue Jan 23, 2024
Closed
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jduo @dgreiss
apacheGH-38614: [Java] Add VarBinary and VarCharWriter helper methods…
802c4a7 
… to more writers (apache#38631)

### Rationale for this change
Add the overrides for new convenience Writer methods added to VarCharWriter and VarBinaryWriter so that classes that
use composition such as UnionWriter and PromotableWriter can invoke them properly.

### What changes are included in this PR?
- Rename from writeTo$type to write$type for consistency with other methods
- Add new helper methods to PromotableWriter
- Add new helper methods to complex writers such as list and union

### Are these changes tested?
Yes. New unit tests added for several Writer classes.

 **This PR includes breaking changes to public APIs.** 
The writeTo<Type>() and similar methods in Writers have been renamed to just write<Type>()

* Closes: apache#38614

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jduo jduo

Labels
Component: Java Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38614: [Java] Add VarBinary and VarCharWriter helper methods to more writers Bit-Quill/arrow
2 participants
@lidavidm @jduo