GH-37705: [Java] Extra input methods for VarChar writers #37883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
Sep 26, 2023
github-actions
bot
added
awaiting changes
Add write() methods for Text and String types. Ensure these methods are part of the writer interfaces and not just the Impls.
jduo
force-pushed
the
37706-java-varchar-writer-inputs
branch
from
dfd280f to
f52977e
Compare
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c07f5bc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
etseidl
pushed a commit
to etseidl/arrow
that referenced
this pull request
Sep 28, 2023
…e#37883) ### Rationale for this change Improve the convenience of using VarCharWriter and LargeVarCharWriter interfaces. Also allow users to avoid unnecessary overhead creating Arrow buffers when writing String and Text data. ### What changes are included in this PR? Add write() methods for Text and String types. Ensure these methods are part of the writer interfaces and not just the Impls.### Are these changes tested? ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37705 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…e#37883) ### Rationale for this change Improve the convenience of using VarCharWriter and LargeVarCharWriter interfaces. Also allow users to avoid unnecessary overhead creating Arrow buffers when writing String and Text data. ### What changes are included in this PR? Add write() methods for Text and String types. Ensure these methods are part of the writer interfaces and not just the Impls.### Are these changes tested? ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37705 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…e#37883) ### Rationale for this change Improve the convenience of using VarCharWriter and LargeVarCharWriter interfaces. Also allow users to avoid unnecessary overhead creating Arrow buffers when writing String and Text data. ### What changes are included in this PR? Add write() methods for Text and String types. Ensure these methods are part of the writer interfaces and not just the Impls.### Are these changes tested? ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37705 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…e#37883) ### Rationale for this change Improve the convenience of using VarCharWriter and LargeVarCharWriter interfaces. Also allow users to avoid unnecessary overhead creating Arrow buffers when writing String and Text data. ### What changes are included in this PR? Add write() methods for Text and String types. Ensure these methods are part of the writer interfaces and not just the Impls.### Are these changes tested? ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37705 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Improve the convenience of using VarCharWriter and LargeVarCharWriter interfaces.
Also allow users to avoid unnecessary overhead creating Arrow buffers when writing
String and Text data.
What changes are included in this PR?
Add write() methods for Text and String types.
Ensure these methods are part of the writer interfaces and not just the Impls.### Are these changes tested?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
byte[]orByteBuffer#37705