Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Support service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3 #38663

Closed
messense opened this issue Nov 10, 2023 · 1 comment · Fixed by #39160
Closed

[C++] Support service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3 #38663

messense opened this issue Nov 10, 2023 · 1 comment · Fixed by #39160
Assignees
@messense
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@messense
Copy link
Member

Describe the enhancement requested

https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html

Service-specific endpoint configuration provides the option to use an endpoint of your choosing for API requests and to have that choice persist. These settings provide flexibility to support local endpoints, VPC endpoints, and third-party local AWS development environments. Different endpoints can be used for testing and production environments. You can specify an endpoint URL for individual AWS services.

#36791 added support for AWS_ENDPOINT_URL, I propose to also add support for AWS_ENDPOINT_URL_S3.
I can contribute a patch if this is an acceptable feature.

Component(s)

C++
@messense messense changed the title Support service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3 [C++] Support service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3 Nov 10, 2023
@pitrou
Copy link
Member

pitrou commented Dec 7, 2023

@messense Sorry for the delay! Yes, this sounds fine to me, feel free to submit a PR.

@messense messense mentioned this issue Dec 10, 2023
Merged
pitrou added a commit that referenced this issue Jan 8, 2024
@messense @pitrou
GH-38663: [C++] Add support for service-specific endpoint for S3 usin…
1362122 
…g `AWS_ENDPOINT_URL_S3` (#39160)

### Rationale for this change

See #38663

### What changes are included in this PR?

set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url.

### Are these changes tested?

unittest

### Are there any user-facing changes?

No

* Closes: #38663

Lead-authored-by: messense <messense@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 16.0.0 milestone Jan 8, 2024
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@messense @pitrou @clayburn
apacheGH-38663: [C++] Add support for service-specific endpoint for S…
6b9f66d 
…3 using `AWS_ENDPOINT_URL_S3` (apache#39160)

### Rationale for this change

See apache#38663

### What changes are included in this PR?

set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url.

### Are these changes tested?

unittest

### Are there any user-facing changes?

No

* Closes: apache#38663

Lead-authored-by: messense <messense@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@messense @pitrou @dgreiss
apacheGH-38663: [C++] Add support for service-specific endpoint for S…
d274984 
…3 using `AWS_ENDPOINT_URL_S3` (apache#39160)

### Rationale for this change

See apache#38663

### What changes are included in this PR?

set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url.

### Are these changes tested?

unittest

### Are there any user-facing changes?

No

* Closes: apache#38663

Lead-authored-by: messense <messense@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@messense @pitrou @zanmato1984
apacheGH-38663: [C++] Add support for service-specific endpoint for S…
855835d 
…3 using `AWS_ENDPOINT_URL_S3` (apache#39160)

### Rationale for this change

See apache#38663

### What changes are included in this PR?

set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url.

### Are these changes tested?

unittest

### Are there any user-facing changes?

No

* Closes: apache#38663

Lead-authored-by: messense <messense@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@severo severo mentioned this issue Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@messense messense

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-38663: [C++] Add support for service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3
2 participants
@messense @pitrou