-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38663: [C++] Add support for service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3
#39160
GH-38663: [C++] Add support for service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3
#39160
Conversation
|
Ping @pitrou can you take a look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @messense ! I've updated the doc, otherwise this LGTM.
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1362122. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…3 using `AWS_ENDPOINT_URL_S3` (apache#39160) ### Rationale for this change See apache#38663 ### What changes are included in this PR? set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url. ### Are these changes tested? unittest ### Are there any user-facing changes? No * Closes: apache#38663 Lead-authored-by: messense <messense@icloud.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
…3 using `AWS_ENDPOINT_URL_S3` (apache#39160) ### Rationale for this change See apache#38663 ### What changes are included in this PR? set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url. ### Are these changes tested? unittest ### Are there any user-facing changes? No * Closes: apache#38663 Lead-authored-by: messense <messense@icloud.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
…3 using `AWS_ENDPOINT_URL_S3` (apache#39160) ### Rationale for this change See apache#38663 ### What changes are included in this PR? set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url. ### Are these changes tested? unittest ### Are there any user-facing changes? No * Closes: apache#38663 Lead-authored-by: messense <messense@icloud.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
See #38663
What changes are included in this PR?
set variable
endpoint_override
according the environment variable, prefer service-specific endpoint url over global endpoint url.Are these changes tested?
unittest
Are there any user-facing changes?
No
AWS_ENDPOINT_URL_S3
#38663