-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Remove unnecessary production dependencies #40108
Comments
arrow2csv is a bin provided by the library so we need to keep it as a dependency. We could probably remove that script, though but that's for another day. I removed swc in #41274. The types should be in the dependencies so people get the right versions. |
I think we only need to export types transitively used by exported libraries, not exported binaries. Since Similarly, I suspect
Alternately, publish as a separate package. Doesn't look like moving or deleting the file would break too much (usages). |
Good point. I'll update the pull request. |
|
Yeah, let's not remove it for now, that's a separate issue. One could argue that cli tools should be separate packages and that js isn't the ideal language for cli tools (which is why I made https://github.com/domoritz/arrow-tools/tree/main/crates/csv2arrow ;-)). |
Describe the enhancement requested
The Apache Arrow JS bundle includes a few unnecessary packages that increase the dependency graph. The culprits are:
@swc/helpers
is never imported. I think it's used forarrow/js/tsconfig.json
Line 22 in 9b931af
Here's the graph of the current dependencies.
Component(s)
JavaScript
The text was updated successfully, but these errors were encountered: