Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python][CI] Build failure with Cython 2 #43707

Closed
pitrou opened this issue Aug 15, 2024 · 3 comments
Closed

[Python][CI] Build failure with Cython 2 #43707

pitrou opened this issue Aug 15, 2024 · 3 comments
Assignees
@lidavidm
Labels
Component: Continuous Integration Component: Python Type: bug
Milestone
18.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Aug 15, 2024

Describe the bug, including details regarding any error messages, version, and platform.

These failures have appeared recently on the test-conda-python-3.10-cython2 Crossbow job:
https://github.com/ursacomputing/crossbow/actions/runs/10396692805/job/28791169422#step:7:3604

  Error compiling Cython file:
  ------------------------------------------------------------
  ...
      """

      cdef:
          c_string c_type_name = tobytes(type_name)
          c_string c_vendor_name = tobytes(vendor_name)
          shared_ptr[CDataType] c_type = make_shared[COpaqueType](
                                                                ^
  ------------------------------------------------------------

  pyarrow/types.pxi:5331:63: Cannot assign type 'shared_ptr[COpaqueType]' to 'shared_ptr[CDataType]'

Component(s)

Continuous Integration, Python
@pitrou
Copy link
Member Author

pitrou commented Aug 15, 2024

cc @lidavidm @jorisvandenbossche

lidavidm added a commit to lidavidm/arrow that referenced this issue Aug 20, 2024
@lidavidm
apacheGH-43707: [Python] Fix compilation on Cython<3
33b739d
@lidavidm lidavidm self-assigned this Aug 20, 2024
@github-actions github-actions bot mentioned this issue Aug 20, 2024
Merged
@jorisvandenbossche
Copy link
Member

FWIW, I think we should also consider simply raising the minimum cython version to something >= 3

jorisvandenbossche pushed a commit that referenced this issue Aug 20, 2024
@lidavidm
GH-43707: [Python] Fix compilation on Cython<3 (#43765)
b0317f2 
### Rationale for this change

Fix compilation on Cython < 3

### What changes are included in this PR?

Add an explicit cast

### Are these changes tested?

N/A

### Are there any user-facing changes?

No
* GitHub Issue: #43707

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 18.0.0 milestone Aug 20, 2024
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 43765
#43765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: Continuous Integration Component: Python Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
3 participants
@lidavidm @jorisvandenbossche @pitrou