-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43707: [Python] Fix compilation on Cython<3 #43765
Conversation
@github-actions crossbow submit test-conda-python-3.10-cython2 |
Revision: 33b739d Submitted crossbow builds: ursacomputing/crossbow @ actions-73720c071b
|
@github-actions crossbow submit -g python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b0317f2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
Fix compilation on Cython < 3
What changes are included in this PR?
Add an explicit cast
Are these changes tested?
N/A
Are there any user-facing changes?
No