Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43707: [Python] Fix compilation on Cython<3 #43765

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Aug 20, 2024

Rationale for this change

Fix compilation on Cython < 3

What changes are included in this PR?

Add an explicit cast

Are these changes tested?

N/A

Are there any user-facing changes?

No

@lidavidm
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.10-cython2

Copy link

Revision: 33b739d

Submitted crossbow builds: ursacomputing/crossbow @ actions-73720c071b

Task Status
test-conda-python-3.10-cython2 GitHub Actions

@lidavidm lidavidm marked this pull request as ready for review August 20, 2024 05:29
@lidavidm lidavidm requested a review from pitrou August 20, 2024 05:29
@pitrou
Copy link
Member

pitrou commented Aug 20, 2024

@github-actions crossbow submit -g python

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you!

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit b0317f2 into apache:main Aug 20, 2024
15 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Aug 20, 2024
@lidavidm lidavidm deleted the gh-43707 branch August 20, 2024 08:05
@github-actions github-actions bot added awaiting committer review Awaiting committer review awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Aug 20, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b0317f2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants