Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [C++] DenseUnionArray #206

Closed
wants to merge 1 commit into from
Closed

Conversation

pcmoritz
Copy link
Contributor

This is work in progress, a first pass at implementing DenseUnionArray for Arrow. It is ported over from ray-project@0707062.

@wesm
Copy link
Member

wesm commented Nov 18, 2016

ARROW-373 contained a bit of refactoring so you'll need to rebase, sorry about that

@pcmoritz pcmoritz force-pushed the master branch 2 times, most recently from 16c6fdc to 11c04a3 Compare November 18, 2016 20:50
@pcmoritz
Copy link
Contributor Author

Thanks for letting me know! Going forward, do you want to have only one union array class and make it dense or sparse depending on the type field?

@pcmoritz pcmoritz force-pushed the master branch 3 times, most recently from d881d71 to 7857113 Compare November 19, 2016 07:32
@wesm
Copy link
Member

wesm commented Nov 26, 2016

that seems acceptable for now, we may want dedicated container classes at some point, though.

@wesm
Copy link
Member

wesm commented Dec 2, 2016

@pcmoritz how would you like to proceed? In the course of implementing unions, we'll also want to add integration tests once ARROW-394 and associated JIRAs are in

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Dec 8, 2016

@wesm Let's try to get this in a form where it is mergeable, this means making the equals function work and having some more tests on the C++ side. I can't yet promise how soon I'll get to that, I hope I'll have time next week. I'm happy if somebody continues on it earlier if this is blocking.

We also should make sure that we have some specification of the binary format so Java and C++ use the same format. I'll probably not look into the Java side any time soon though.

@wesm
Copy link
Member

wesm commented Dec 30, 2016

Since I've done a lot of work recently on the IPC code and integration testing and have that all fresh in my head, I'll go ahead and do the union implementation in the next week or two. Will report back

@asfgit asfgit closed this in 9f7d4ae Jan 3, 2017
wesm added a commit to wesm/arrow that referenced this pull request Sep 2, 2018
Depends on ARROW-374. Need to merge that and update the thirdparty git hash

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes apache#206 from wesm/PARQUET-812 and squashes the following commits:

73fb8d0 [Wes McKinney] Update thirdparty arrow version
5db7908 [Wes McKinney] typo
fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray
wesm added a commit to wesm/arrow that referenced this pull request Sep 4, 2018
Depends on ARROW-374. Need to merge that and update the thirdparty git hash

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes apache#206 from wesm/PARQUET-812 and squashes the following commits:

73fb8d0 [Wes McKinney] Update thirdparty arrow version
5db7908 [Wes McKinney] typo
fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray

Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
wesm added a commit to wesm/arrow that referenced this pull request Sep 6, 2018
Depends on ARROW-374. Need to merge that and update the thirdparty git hash

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes apache#206 from wesm/PARQUET-812 and squashes the following commits:

73fb8d0 [Wes McKinney] Update thirdparty arrow version
5db7908 [Wes McKinney] typo
fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray

Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
wesm added a commit to wesm/arrow that referenced this pull request Sep 7, 2018
Depends on ARROW-374. Need to merge that and update the thirdparty git hash

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes apache#206 from wesm/PARQUET-812 and squashes the following commits:

73fb8d0 [Wes McKinney] Update thirdparty arrow version
5db7908 [Wes McKinney] typo
fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray

Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
wesm added a commit to wesm/arrow that referenced this pull request Sep 8, 2018
Depends on ARROW-374. Need to merge that and update the thirdparty git hash

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes apache#206 from wesm/PARQUET-812 and squashes the following commits:

73fb8d0 [Wes McKinney] Update thirdparty arrow version
5db7908 [Wes McKinney] typo
fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray

Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants