-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [C++] DenseUnionArray #206
Conversation
ARROW-373 contained a bit of refactoring so you'll need to rebase, sorry about that |
16c6fdc
to
11c04a3
Compare
Thanks for letting me know! Going forward, do you want to have only one union array class and make it dense or sparse depending on the type field? |
d881d71
to
7857113
Compare
that seems acceptable for now, we may want dedicated container classes at some point, though. |
@wesm Let's try to get this in a form where it is mergeable, this means making the equals function work and having some more tests on the C++ side. I can't yet promise how soon I'll get to that, I hope I'll have time next week. I'm happy if somebody continues on it earlier if this is blocking. We also should make sure that we have some specification of the binary format so Java and C++ use the same format. I'll probably not look into the Java side any time soon though. |
Since I've done a lot of work recently on the IPC code and integration testing and have that all fresh in my head, I'll go ahead and do the union implementation in the next week or two. Will report back |
Depends on ARROW-374. Need to merge that and update the thirdparty git hash Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#206 from wesm/PARQUET-812 and squashes the following commits: 73fb8d0 [Wes McKinney] Update thirdparty arrow version 5db7908 [Wes McKinney] typo fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray
Depends on ARROW-374. Need to merge that and update the thirdparty git hash Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#206 from wesm/PARQUET-812 and squashes the following commits: 73fb8d0 [Wes McKinney] Update thirdparty arrow version 5db7908 [Wes McKinney] typo fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
Depends on ARROW-374. Need to merge that and update the thirdparty git hash Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#206 from wesm/PARQUET-812 and squashes the following commits: 73fb8d0 [Wes McKinney] Update thirdparty arrow version 5db7908 [Wes McKinney] typo fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
Depends on ARROW-374. Need to merge that and update the thirdparty git hash Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#206 from wesm/PARQUET-812 and squashes the following commits: 73fb8d0 [Wes McKinney] Update thirdparty arrow version 5db7908 [Wes McKinney] typo fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
Depends on ARROW-374. Need to merge that and update the thirdparty git hash Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#206 from wesm/PARQUET-812 and squashes the following commits: 73fb8d0 [Wes McKinney] Update thirdparty arrow version 5db7908 [Wes McKinney] typo fc0d559 [Wes McKinney] Read unadorned BYTE_ARRAY into arrow::BinaryArray Change-Id: I9466e3eb082fee464e832b3106223ac48b0afb4a
This is work in progress, a first pass at implementing DenseUnionArray for Arrow. It is ported over from ray-project@0707062.