ARROW-108: [C++] Add Union implementation and IPC/JSON serialization tests #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xample in IPC Change-Id: Icc5c3f9a5080d3853ed6382f714b8a1ee2595adf
…rmat because of include order sensitivity Change-Id: I5376a75ca2df817570b1e6cf929bfd64e0809333
xhochy
requested changes
Jan 2, 2017
| using TypeClass = UnionType; | ||
|
|
||
| UnionArray(const TypePtr& type, int32_t length, | ||
| std::vector<std::shared_ptr<Array>>& children, |
| std::vector<std::shared_ptr<Array>>& children, | ||
| const std::shared_ptr<Buffer>& type_ids, | ||
| const std::shared_ptr<Buffer>& offsets = nullptr, int32_t null_count = 0, | ||
| std::shared_ptr<Buffer> null_bitmap = nullptr); |
Change-Id: I69146616629ba3adcee56f63133fe9bd59922c5e
Change-Id: If418d5862fbe84e0623c82fc74ecab5f89f86eef
Change-Id: I02a81e35f277fb08ad54ffafec878ff9e7b025e7
|
Tests are completed |
|
Removed ArrayPtr completely |
Change-Id: Ie49471df170207c6a9ce7be3601096e8f48d2204
wesm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206.
Still need to add test cases for JSON read/write and dense union IPC. Integration tests can happen in a subsequent PR (but the Java library does not support dense unions yet, so sparse only -- i.e. no offsets vector)