-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-42006: [CI][Python] Use pip install -e instead of setup.py build_ext --inplace for installing pyarrow on verification script #42007
Conversation
…nd setuptools>=64 for Python verification
@github-actions crossbow submit verify-rc-source-python-* |
This comment was marked as outdated.
This comment was marked as outdated.
I was missing dev tags on my fork that's why the jobs failed to generate the correct version, I've pushed them and will re-run |
@github-actions crossbow submit verify-rc-source-python-* |
Revision: ec8ce7e Submitted crossbow builds: ursacomputing/crossbow @ actions-d9b2b774f4 |
@@ -756,7 +756,7 @@ test_python() { | |||
show_header "Build and test Python libraries" | |||
|
|||
# Build and test Python | |||
maybe_setup_virtualenv "cython>=0.29.31" numpy "setuptools_scm<8.0.0" setuptools | |||
maybe_setup_virtualenv "cython>=0.29.31" numpy "setuptools_scm>=8.0.0" "setuptools>=64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, for release verification I think we should actually remove this line entirely, and rely on the fact that we specify those dependencies in pyproject.toml (i.e. replacing the python setup.py build_ext --inplace
below with python -m pip install (-e) .
The |
…pt of python setup.py build_ext --inplace
@github-actions crossbow submit verify-rc-source-python-linux-ubuntu-20.04-amd64 |
Revision: f098baf Submitted crossbow builds: ursacomputing/crossbow @ actions-75636dfc2c
|
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@github-actions crossbow submit verify-rc-source-python-linux-ubuntu-20.04-amd64 |
Revision: f39efac Submitted crossbow builds: ursacomputing/crossbow @ actions-ac4eb35fba
|
I don't think running the other extra CI is required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The verify-rc-source-python-linux-almalinux-8-amd64
failure is #39695.
Workaround:
👍 Updated title + description with final fix! |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a045770. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Due to #37929 we require a higher version of setuptools and setuptools_scm to be installed otherwise the job fails with setuptools_scm failing with
TypeError: Configuration.__init__() got an unexpected keyword argument 'version_file'
What changes are included in this PR?
Remove the dependencies for the environment and let installation handle those using pip install -e instead of setup.py build_ext --inplace for installing pyarrow on verification script
Are these changes tested?
Via Archery
Are there any user-facing changes?
No