Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage PrismRunner implementation and dependencies #31794

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Stage PrismRunner implementation and dependencies #31794

merged 3 commits into from
Jul 8, 2024

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Jul 7, 2024 •
edited
Loading

This PR addresses #31792 staging work for #31792 and #31402.

cc: @lostluck

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

This was referenced Jul 7, 2024
Merged
Merged
@damondouglas damondouglas marked this pull request as ready for review July 8, 2024 05:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damondouglas
Copy link
Contributor Author

assign set of reviewers

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

ahmedabu98
ahmedabu98 reviewed Jul 8, 2024
View reviewed changes
runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismPipelineOptions.java Outdated Show resolved Hide resolved
runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismPipelineOptions.java
Comment on lines +31 to +33
+ "Beam Github Release page URL, with a matching --prismVersionOverride "
+ "set. This option overrides all others for finding a prism binary.")
String getPrismLocation();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the descriptions I'm still a little confused on how prismLocation and prismVersionOverride work together. If using a Github release page, should one set the same page for both options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ahmedabu98 . It follows the Python prism_runner options so that there's consistency.

runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismRunner.java Show resolved Hide resolved
@damondouglas
Copy link
Contributor Author

R: @ahmedabu98

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damondouglas @ahmedabu98
Update runners/prism/java/src/main/java/org/apache/beam/runners/prism…
d79d5d2 
…/PrismPipelineOptions.java

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
@github-actions github-actions bot added build and removed java labels Jul 8, 2024
ahmedabu98
ahmedabu98 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damondouglas damondouglas merged commit 631d40d into apache:master Jul 8, 2024
24 checks passed
@damondouglas damondouglas deleted the prism-java-runner-wrapper-setup branch July 8, 2024 17:30
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
@damondouglas @ahmedabu98 @acrites
Stage PrismRunner implementation and dependencies (apache#31794)
2a49415 
* Stage PrismRunner implementation and dependencies

* Fix missing license on package-info

* Update runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismPipelineOptions.java

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>

---------

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedabu98 ahmedabu98 ahmedabu98 approved these changes

Assignees
No one assigned
Labels
build Next Action: Reviewers prism runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damondouglas @ahmedabu98