Update Dataflow internal client test #32471
Conversation
| @@ -998,12 +998,12 @@ def test_interpreter_version_check_passes_with_experiment(self): | |||
|
|
|||
| @mock.patch( | |||
| 'apache_beam.runners.dataflow.internal.apiclient.sys.version_info', | |||
| (3, 8, 2)) | |||
There was a problem hiding this comment.
there is benefit to keep this aligned with the lowest supported version.
Hence question - do we drop Py3.8 support in the upcoming release or the following release? I forgot where we landed on in that conversation.
There was a problem hiding this comment.
No one really felt strongly either way, which is why this kept moving forward with the testing changes.
I can swing this back to 3.9 no problem
There was a problem hiding this comment.
reading
we drop support in Dataflow for python 3.9 in the upcoming release.There was a problem hiding this comment.
so if the plan was to "move tests to 3.9 now, but still support Python 3.8 for one more release", then we strayed from that plan
There was a problem hiding this comment.
this test essentially tests that Python 3.8 is still supported on Dataflow.
There was a problem hiding this comment.
If that's actually how we want to go about it then that's fine, but I'm of the opinion that if we're not testing things we're better off moving forward with removing support. I can put 3.8 back on that list for now if that's preferred and we can move this discussion to a later PR actually removing 3.8 support from beam proper
There was a problem hiding this comment.
this file was probably updated too early anyway IMO, best to leave it for the in-package removal
There was a problem hiding this comment.
If that's actually how we want to go about it then that's fine, but I'm of the opinion that if we're not testing things we're better off moving forward with removing support.
yeah, I am of the same opinion as you; my understanding was that this was a compromise b/w start the cleanup work now and also delay the deprecation for a little longer.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Looks like you also need to re-instate this "ignore" comment: bbd09d6#diff-b16eff1945003295256595d8a30c02515ba24aebb2ad7c8bc81ace56ebc3aabeL243 |
* Update Dataflow internal client test * update to python 3.9 * restore 3.8 to versions list * restore unit test
Fixes a breakage causing the coverage precommit to go red. Updates the test to a later python version to exercise the code
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.