Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dataflow internal client test #32471

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Update Dataflow internal client test #32471

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
944d3ee
Update Dataflow internal client test
jrmccluskey Sep 16, 2024
19d4f97
update to python 3.9
jrmccluskey Sep 16, 2024
4f19408
restore 3.8 to versions list
jrmccluskey Sep 16, 2024
17fc2c6
restore unit test
jrmccluskey Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,12 +998,12 @@ def test_interpreter_version_check_passes_with_experiment(self):

@mock.patch(
'apache_beam.runners.dataflow.internal.apiclient.sys.version_info',
(3, 8, 2))
Copy link
Contributor

@tvalentyn tvalentyn Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is benefit to keep this aligned with the lowest supported version.

Hence question - do we drop Py3.8 support in the upcoming release or the following release? I forgot where we landed on in that conversation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No one really felt strongly either way, which is why this kept moving forward with the testing changes.

I can swing this back to 3.9 no problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading

beam/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py

Line 85 in e005591

_PYTHON_VERSIONS_SUPPORTED_BY_DATAFLOW = ['3.9', '3.10', '3.11', '3.12']
we drop support in Dataflow for python 3.9 in the upcoming release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if the plan was to "move tests to 3.9 now, but still support Python 3.8 for one more release", then we strayed from that plan

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test essentially tests that Python 3.8 is still supported on Dataflow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's actually how we want to go about it then that's fine, but I'm of the opinion that if we're not testing things we're better off moving forward with removing support. I can put 3.8 back on that list for now if that's preferred and we can move this discussion to a later PR actually removing 3.8 support from beam proper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was probably updated too early anyway IMO, best to leave it for the in-package removal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's actually how we want to go about it then that's fine, but I'm of the opinion that if we're not testing things we're better off moving forward with removing support.

yeah, I am of the same opinion as you; my understanding was that this was a compromise b/w start the cleanup work now and also delay the deprecation for a little longer.

(3, 12, 2))
@mock.patch(
'apache_beam.runners.dataflow.internal.apiclient.'
'beam_version.__version__',
'2.2.0')
def test_interpreter_version_check_passes_py38(self):
def test_interpreter_version_check_passes_py312(self):
pipeline_options = PipelineOptions([])
apiclient._verify_interpreter_version_is_supported(pipeline_options)

Expand Down
Loading