Filter Synthetic Methods in PipelineOptionsFactory #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @lukecwik |
| void setValue(Number value); | ||
| } | ||
|
|
||
| private static interface SubtypeReturingOpts extends Opts { |
There was a problem hiding this comment.
SubtypeReturingOpts -> SubtypeReturningOptions
|
Add a comment to PipelineOptions / PipelineOptionsFactory stating that we don't support java8's default methods. |
Opts -> Options for all class declarations Add a note that the value of a default method is ignored.
davorbonaci
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Mar 25, 2016
aljoscha
pushed a commit
to aljoscha/beam
that referenced
this pull request
Mar 28, 2018
Use character replacement instead of regex for artifact flattening
tvalentyn
pushed a commit
to tvalentyn/beam
that referenced
this pull request
May 15, 2018
mynameborat
referenced
this pull request
in mynameborat/beam
Aug 2, 2022
* Suppress RandomModInteger Warnings Suppress RandomModInteger warnings since we are looking for a 1/n chance of being 0 as expected. https://errorprone.info/bugpattern/RandomModInteger * Increase Version
sjvanrossum
pushed a commit
to sjvanrossum/beam
that referenced
this pull request
May 22, 2023
refactor: CoderUrnTree and dyn Coder
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/python-firestore/compare/v1.6.2...v1.7.0) (2020-05-18) ### Features * Create CODEOWNERS ([apache#40](https://www.github.com/googleapis/python-firestore/issues/40)) ([a0cbf40](https://www.github.com/googleapis/python-firestore/commit/a0cbf403fe88f07c83bec81f275ac168be573e93)) ### Bug Fixes * **firestore:** fix get and getall method of transaction ([apache#16](https://www.github.com/googleapis/python-firestore/issues/16)) ([de3aca0](https://www.github.com/googleapis/python-firestore/commit/de3aca0e78b68f66eb76bc679c6e95b0746ad590)) * Update team to be in correct org ([apache#43](https://www.github.com/googleapis/python-firestore/issues/43)) ([bef5a3a](https://www.github.com/googleapis/python-firestore/commit/bef5a3af4613b5f9d753bb6f45275e480e4bb301)) * **firestore:** fix lint ([apache#48](https://www.github.com/googleapis/python-firestore/issues/48)) ([7fa00c4](https://www.github.com/googleapis/python-firestore/commit/7fa00c49dc3fab1d687fff9246f3e5ff0682cac0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the testReturnTypeConflcitThrows when compiled with java 8, which inserts a bridge method which is reported as a a conflicting type (even though it is an effect of a conflicting type rather than a cause, and the user cannot change anything about it)