build: disable BookieZKExpireTest beyond jdk17 #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
jiazhai
approved these changes
Apr 27, 2024
zhiheng123
pushed a commit
to zhiheng123/bookkeeper
that referenced
this pull request
Jun 5, 2024
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
zhiheng123
pushed a commit
to zhiheng123/bookkeeper
that referenced
this pull request
Jun 7, 2024
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As of JDK 21, the methods
suspendandresumeon theThreadclass throwUnsupportedOperationException.Changes
@EnabledForJreRange(max = JRE.JAVA_17)(It's modern and better than junit4) to tests that usesuspendandresume, effectively disabling these tests on JDK versions higher than 17 where these methods are not supported.