Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][Branch 4.16]ci: fix ci test #4420

Closed
wants to merge 3 commits into from
Closed

[WIP][Branch 4.16]ci: fix ci test #4420

wants to merge 3 commits into from

Conversation

zhiheng123
Copy link
Contributor

@zhiheng123 zhiheng123 commented Jun 5, 2024 •
edited
Loading

Descriptions of the changes in this PR:

Changes

(Describe: what changes you have made)

I found that this exception was caused by the upgrade of netty. If you
revert netty to 4.1.100.Final, the use case passes. Because in
4.1.101.Final, netty modified the Http2 related interfaces, the connection
is as follows: https://netty.io/news/2023/11/09/4-1-101-Final.html

The main reason may be incompatibility caused by (#13651). I recommended
to roll back netty to 4.1.100.Final, which can also address some CVE
vulnerabilities related to netty. This will allow the ci of branch-4.1.16
to return to normal without having to upgrade the version of grpc. The
corresponding components related to netty such as vertx also need to be
rolled back to the version that matches netty.

shoothzj
shoothzj requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@shoothzj shoothzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we split the netty downgrade and jdk21 support.

dlg99
dlg99 requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill in PR description to explain what is the problem you are trying to solve, how netty downgrade fits in it, etc.

@zhiheng123 zhiheng123 changed the title [Branch 4.16]ci: fix ci test [WIP][Branch 4.16]ci: fix ci test Jun 7, 2024
shoothzj and others added 3 commits June 7, 2024 17:21
@shoothzj @zhiheng123
build: disable BookieZKExpireTest beyond jdk17 (apache#4309)
6a85eed 
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@shoothzj @zhiheng123
build: disable testNewEnsembleBookieWithOneEmptyRegion method in Test…
6e92a36 
…RegionAwareEnsemblePlacementPolicy beyond jdk11 (apache#4323)

### Motivation

In JDK21, it's is no way to change private static final variable currently, before figure out how to replace, disable it first

```
        Field logField = repp.getClass().getDeclaredField("LOG");
        Logger mockLogger = mock(Logger.class);
        Field modifiers = Field.class.getDeclaredField("modifiers");
        modifiers.setAccessible(true);
        modifiers.setInt(logField, logField.getModifiers() & ~Modifier.FINAL);
```

See also https://issues.apache.org/jira/browse/CASSANDRA-18181

### Changes

1. Added junit5 annotation `@EnabledForJreRange(max = JRE.JAVA_17)`(It's modern and better than junit4) to tests that use `suspend` and `resume`, effectively disabling these tests on JDK versions higher than 17 where these methods are not supported.
2. BookieZKExpireTest should be annotated as junit5 test.
3. Make `BookKeeperClusterTestCase` compatible to junit5.

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@zhiheng123
fix: revert netty to 4.1.100.Final
cbb2f55 
Signed-off-by: zhiheng123 <903292776@qq.com>
@zhiheng123 zhiheng123 changed the title [WIP][Branch 4.16]ci: fix ci test [Branch 4.16]ci: fix ci test Jun 7, 2024
@zhiheng123 zhiheng123 changed the title [Branch 4.16]ci: fix ci test [WIP][Branch 4.16]ci: fix ci test Jun 7, 2024
@shoothzj shoothzj mentioned this pull request Jun 12, 2024
Merged
@shoothzj shoothzj closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlg99 dlg99 dlg99 requested changes

@shoothzj shoothzj shoothzj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhiheng123 @dlg99 @shoothzj