-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/747 fix codecov #748
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #748 +/- ##
==========================================
+ Coverage 90.17% 90.20% +0.03%
==========================================
Files 223 225 +2
Lines 26545 26393 -152
==========================================
- Hits 23936 23807 -129
+ Misses 2609 2586 -23 ☔ View full report in Codecov by Sentry. |
.github/workflows/coverage.yml
Outdated
@@ -67,7 +67,9 @@ jobs: | |||
source deactivate_conanrun.sh | |||
lcx="lcov --output-file=coverage.info " && for i in `find . -name "*.info.cleaned"`; do lcx+=" --add-tracefile=$i"; done && $lcx | |||
- name: Codecov | |||
uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457 | |||
uses: codecov/codecov-action@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per advise of the Apache Infra team, please use the hash/checksum here instead of a tag.
also see 2ca790d were we did this for the previous version
Note the coverage also dropped to about 60%. I think is because the test sources are also includes and |
I am still testing some small changes to see if I can get a cleaner log. After that, I will create a new pull request with a single commit to fix codecov. In my opinion, the small trial and error commits in this PR will unnecessarily clutter the commit log. |
Hotfix pull request that fixes the codecov upload issue, by using a GitHub codecov token secret.
This is a hotfix and as such will follow the merge then review procedure.
Closes #747