Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/747 fix codecov #748

Closed
wants to merge 9 commits into from
Closed

Feature/747 fix codecov #748

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cef04fc
gh-747: Add upload token to codecov action
pnoltes May 27, 2024
c51c1d7
gh-747: Fix codecov action version
pnoltes May 27, 2024
b63449f
gh-747: Update codecov action version to commit hash
pnoltes Jun 1, 2024
fb6f0e8
gh-747: Add ignore for gtest sources for codecov
pnoltes Jun 1, 2024
e037cf6
gh-685: Test disable_search codecov action option
pnoltes Jun 2, 2024
b1d35ca
gh-685: Revert codecov.yml changes and remove gnco files
pnoltes Jun 2, 2024
68614c8
gh-685: Revert removal of gnco files
pnoltes Jun 2, 2024
e9ed1cb
gh-685: Use file instead of files for codecov action
pnoltes Jun 2, 2024
8b30826
gh-747: Add coverage.py to build container
pnoltes Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ jobs:
source deactivate_conanrun.sh
lcx="lcov --output-file=coverage.info " && for i in `find . -name "*.info.cleaned"`; do lcx+=" --add-tracefile=$i"; done && $lcx
- name: Codecov
uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457
uses: codecov/codecov-action@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per advise of the Apache Infra team, please use the hash/checksum here instead of a tag.

also see 2ca790d were we did this for the previous version

if: github.repository_owner == 'apache'
with:
files: build/coverage.info
name: codecov-celix
token: ${{ secrets.CODECOV_TOKEN }}
Loading