Unit tests for android_sdk and AndroidProject #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 52.03% 52.59% +0.56%
==========================================
Files 17 17
Lines 1695 1694 -1
Branches 312 312
==========================================
+ Hits 882 891 +9
+ Misses 813 803 -10
Continue to review full report at Codecov.
|
dpogue
approved these changes
Jul 3, 2018
raphinesse
reviewed
Jul 3, 2018
| @@ -95,7 +94,7 @@ module.exports.list_targets = function () { | |||
| } else throw err; | |||
| }).then(function (targets) { | |||
| if (targets.length === 0) { | |||
| return Q.reject(new Error('No android targets (SDKs) installed!')); | |||
| return Promise.reject(new Error('No android targets (SDKs) installed!')); | |||
There was a problem hiding this comment.
I prefer to simply throw the Errors instead of wrapping them in a rejection and returning them. Might be personal taste though
There was a problem hiding this comment.
I have no strong feelings either way. But, when replacing Q, I wanted to keep the changes as simple as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
This is the last unit test PR for today, I promise! The
AndroidProjecttests were originally in #458. This PR also contains increased test coverage forandroid_sdk.js. I have also refactored that to removeQ, as with the other PRs I submitted today.What testing has been done on this change?
Run unit tests
Checklist