Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for android_sdk and AndroidProject #464

Merged
merged 3 commits into from
Sep 2, 2018
Merged

Unit tests for android_sdk and AndroidProject #464

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fea751
Add some unit tests for AndroidProject.js
Menardi Jun 25, 2018
18f2736
CB-14158: Refactor android_sdk to remove Q
Menardi Jul 3, 2018
64aef32
Add unit tests for android_sdk
Menardi Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bin/templates/cordova/lib/android_sdk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
under the License.
*/

var Q = require('q');
var superspawn = require('cordova-common').superspawn;

var suffix_number_regex = /(\d+)$/;
Expand Down Expand Up @@ -95,7 +94,7 @@ module.exports.list_targets = function () {
} else throw err;
}).then(function (targets) {
if (targets.length === 0) {
return Q.reject(new Error('No android targets (SDKs) installed!'));
return Promise.reject(new Error('No android targets (SDKs) installed!'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to simply throw the Errors instead of wrapping them in a rejection and returning them. Might be personal taste though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong feelings either way. But, when replacing Q, I wanted to keep the changes as simple as possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

}
return targets;
});
Expand Down