CB-14145 pin more added bundled deps in 5.0.x patch only #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to clear the red highlights in npm outdated --depth=0
brodycj
deleted the
cb-14145-pin-more-added-bundled-deps-in-5.0.x-patch-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
5.0.xonly - needed to clear the red highlights innpm outdated --depth=0ref: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#check-dependenciesWhat testing has been done on this change?
npm testpasses on personal mac systemnpm testpasses on AppVeyor CI & Travis CIcordova platform add github:brodybits/cordova-browser#cb-14145-pin-more-added-bundled-deps-in-5.0.x-patch-onlythen run using npm@2.15.11 (bundled with deprecated node v4.9.1)cordova platform add github:brodybits/cordova-browser#cb-14145-pin-more-added-bundled-deps-in-5.0.x-patch-onlythen run using npm@5.6.0 (bundled with node v8.11.3)cordova platform add github:brodybits/cordova-browser#cb-14145-pin-more-added-bundled-deps-in-5.0.x-patch-onlythen run and try a couple dialogs using npm@2.15.11 (bundled with deprecated node v4.9.1)Checklist
Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.