CB-14230 patch release 5.0.4 #55
Conversation
major changes? Typo? |
RELEASENOTES.md
Outdated
| * [CB-9366](https://issues.apache.org/jira/browse/CB-9366) - log `error.stack` in `cordova.js` (update from `cordova-js@4.2.4`) in `5.0.x` | ||
| * [GH-53](https://github.com/apache/cordova-browser/pull/53) add Node.js 10 to AppVeyor CI and Travis CI (`5.0.x`) | ||
|
|
||
| ### 5.0.3 (Dec 20, 2017) |
There was a problem hiding this comment.
Unrelated changes - should those be here?
There was a problem hiding this comment.
@janpio I will assume that you mean the old 5.0.3 RELEASENOTE changes. These changes are needed somewhere since someone forgot to do them before making 5.0.3 release. I would be happy to move these to a separate PR.
There was a problem hiding this comment.
Yes, I commented on that line exactly - Github just uselessly displays some more lines to confuse you :/
I don't really care about the separate PR, just mention it in the PR description - so no one can assume it is accidental (as I did).
There was a problem hiding this comment.
just mention it in the PR description
done (my bad)
Reworded to "most important changes" in the description. |
brodycj
changed the title
RELEASENOTES.md
Outdated
| ### 5.0.4 (Jul 30, 2018) | ||
| * [CB-14145](https://issues.apache.org/jira/browse/CB-14145) update dependencies to resolve `npm audit` issues, pinned in `5.0.x` only ([GH-53](https://github.com/apache/cordova-browser/pull/53)) | ||
| * [CB-9366](https://issues.apache.org/jira/browse/CB-9366) - log `error.stack` in `cordova.js` (update from `cordova-js@4.2.4`) in `5.0.x` | ||
| * [GH-53](https://github.com/apache/cordova-browser/pull/53) add Node.js 10 to AppVeyor CI and Travis CI (`5.0.x`) |
There was a problem hiding this comment.
Adding Node.js 10 to CI was not really part of GH-53, will fix this once I resolve a few more red entries in npm outdated --depth=0 as discussed in the description.
There was a problem hiding this comment.
Now fixed, continuing with tests before pushing to 5.0.x
brodycj
changed the title
Platforms affected
browser
What does this PR do?
5.0.3(was forgotten in the5.0.3release)5.0.45.0.4on5.0.xbranch using the following command with updates from Improve patch release support cordova-coho#176:./cordova-coho/coho prepare-platform-release-branch --version 5.0.4 -r browser 5.0.xThis release includes the following changes:
error.stackincordova.js(update fromcordova-js@4.2.4) in5.0.x(ef012e3)5.0.x(57fdfc8)npm auditissues, pinned in5.0.xonly (CB-14145 resolve npm audit issues in patch release #53)npm outdated --depth=0)npm outdated --depth=0What testing has been done on this change?
npm auditshows 0 vulnerabilities (using npm@6.2.0)npm outdated --depth=0shows no red entriescoho audit-license-headers -r browsershows no missing license headerscoho check-license -r browsershows no incorrect licenses (NOTE: this patch release now includesxmldompackage which does not have correct SPDX expression; however, visual inspection ofnode_modules/xmldom/LICENSEshows MIT license option, which is acceptable.)npm testsucceeds on local machinenpm testsucceeds on AppVeyor CI & Travis CIcordova platform add github:brodybits/cordova-browser#5.0.x, run, and try a couple dialogs with npm@2.15.11 (bundled with deprecated node v4.9.1) on Windows Edge, Windows Chrome, and macOS Safaricordova platform add github:brodybits/cordova-browser#5.0.x, run, and try a couple dialogs with npm@5.6.0 (bundled with node v8.11.3)Checklist
Reported an issue in the JIRA databaseAdded automated test coverage as appropriate for this change.