Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14145 pin even more added bundled deps in 5.0.x only #56

Conversation

brodycj
Copy link

@brodycj brodycj commented Jul 30, 2018

Platforms affected

browser

What does this PR do?

  • pin even more added bundled deps in 5.0.x only - needed to clear the red highlights in npm outdated --depth=0

What testing has been done on this change?

  • npm audit shows 0 vulnerabilities (using npm@6.2.0)
  • npm outdated --depth=0 shows no red entries
  • coho audit-license-headers -r browser shows no missing license headers
  • coho check-license -r browser shows no incorrect licenses (NOTE: this patch release now includes xmldom package which does not have correct SPDX expression; however, visual inspection of node_modules/xmldom/LICENSE shows MIT license option, which is acceptable.)
  • npm test succeeds on AppVeyor CI & Travis CI
  • able to add to new Cordova project using cordova platform add github:brodybits/cordova-browser#cb-14145-pin-even-more-added-bundled-deps-in-5.0.x-only then run using npm@2.15.11 (bundled with deprecated node v4.9.1 version)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

needed to clear the red highlights in npm outdated --depth=0
@brodycj brodycj self-assigned this Jul 30, 2018
@brodycj brodycj merged commit 6fcbc63 into apache:5.0.x Jul 30, 2018
@brodycj brodycj deleted the cb-14145-pin-even-more-added-bundled-deps-in-5.0.x-only branch July 30, 2018 23:54
@brodycj brodycj mentioned this pull request Jul 31, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant