Skip to content

Commit

Permalink
CB-13303 : added noprod/production as an option, no prod turns off pr…
Browse files Browse the repository at this point in the history
…oduction

 This closes #287
  • Loading branch information
audreyso authored and stevengill committed Oct 4, 2017
1 parent 72ff10f commit b876e6b
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 2 deletions.
13 changes: 13 additions & 0 deletions spec/cli.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,19 @@ describe('cordova cli', function () {
done();
});
});

it('(add) will pass noprod:true and production:false', function (done) {
cli(['node', 'cordova', 'plugin', 'add', 'device', '--noprod'], function () {
expect(cordova.plugin).toHaveBeenCalledWith(
'add',
['device'],
jasmine.any(Object)
);
var opts = cordova.plugin.calls.argsFor(0)[2];
expect(opts.production).toBe(false);
done();
});
});
});

describe('telemetry', function () {
Expand Down
17 changes: 15 additions & 2 deletions src/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ var knownOpts = {
'nobuild': Boolean,
'list': Boolean,
'buildConfig': String,
'template': String
'template': String,
'production': Boolean,
'noprod': Boolean
};

var shortHands = {
Expand Down Expand Up @@ -450,6 +452,12 @@ function cli (inputArgs) {
args.save = true;
}

if (args.noprod) {
args.production = false;
} else {
args.production = true;
}

if (args.save === undefined) {
// User explicitly did not pass in save
args.save = conf.get('autosave');
Expand All @@ -466,6 +474,10 @@ function cli (inputArgs) {
// User explicitly did not pass in searchpath
args.searchpath = conf.get('searchpath');
}
if (args.production === undefined) {
// User explicitly did not pass in noprod
args.production = conf.get('production');
}

if (args['save-exact'] === undefined) {
// User explicitly did not pass in save-exact
Expand All @@ -482,7 +494,8 @@ function cli (inputArgs) {
save: args.save,
save_exact: args['save-exact'] || false,
shrinkwrap: args.shrinkwrap || false,
force: args.force || false
force: args.force || false,
production: args.production
};
return cordova[cmd](subcommand, targets, download_opts);
}
Expand Down

0 comments on commit b876e6b

Please sign in to comment.