CB-13303 : added noprod/production as an option, no prod turns off pr… #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengill
reviewed
Oct 3, 2017
src/cli.js
Outdated
| // User explicitly did not pass in noprod | ||
| args.production = conf.get('production'); | ||
| } | ||
| if (args.noprod === undefined) { |
There was a problem hiding this comment.
lets not offer noprod in config. Just args.production. We only need noprod like you have in line 454. Used to figure out of args.production is true or false.
stevengill
reviewed
Oct 3, 2017
src/cli.js
Outdated
| force: args.force || false | ||
| force: args.force || false, | ||
| production: args.production, | ||
| noprod: args.noprod || false |
There was a problem hiding this comment.
no need to pass noprod, it is only used to figure out production. Which you do on L454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oduction
Platforms affected
What does this PR do?
Added noprod/production as an option
What testing has been done on this change?
Checklist