CB-14074 ios: Remove Node 4 support from CI & package.json #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drops Node 4 from travis and appveyor - Increase the engine requirement of node in package.json - Added engineStrict to package.json. (Match with other platforms e.g cordova-android) - Cleanup .travis.yml
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 63.99% 63.99%
=======================================
Files 14 14
Lines 1697 1697
Branches 286 286
=======================================
Hits 1086 1086
Misses 611 611Continue to review full report at Codecov.
|
This was referenced Jun 23, 2018
12 tasks
|
I like this in general. As I said elsewhere (#377 (comment)) I would favor dropping Node.js 4, removing the committed node_modules, and increasing the package version to 5.0.0-dev all at the same time, will ask for agreement on the mailing list. |
brodycj
changed the title
brodycj
approved these changes
Aug 2, 2018
erisu
added a commit
to erisu/cordova-ios
that referenced
this pull request
Jan 16, 2019
- Drops Node 4 from travis and appveyor - Increase the engine requirement of node in package.json - Added engineStrict to package.json. (Match with other platforms e.g cordova-android) - Cleanup .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
What testing has been done on this change?
Checklist