Fixed Get Apple OSX Version method #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified RegEx pattern to look for new SDK pattern 'macOS'
12 tasks
|
I discovered a few TODO items after merging:
P.S. I took the liberty to edit the Checklist section. |
brodycj
pushed a commit
to brodycj/cordova-ios
that referenced
this pull request
Jul 31, 2018
(was part of apacheGH-377) covers update from apacheGH-376 Co-authored-by: エリス <ellis.bryan@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
brodycj
pushed a commit
to brodycj/cordova-ios
that referenced
this pull request
Jul 31, 2018
(was part of apacheGH-377) covers update from apacheGH-376 Co-authored-by: エリス <ellis.bryan@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
4 tasks
brodycj
pushed a commit
to brodycj/cordova-ios
that referenced
this pull request
Jul 31, 2018
(was part of apacheGH-377) covers update from apacheGH-376 Co-authored-by: エリス <ellis.bryan@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
brodycj
pushed a commit
that referenced
this pull request
Jul 31, 2018
erisu
added a commit
to erisu/cordova-ios
that referenced
this pull request
Jan 16, 2019
(was part of apacheGH-377) covers update from apacheGH-376 Co-authored-by: エリス <ellis.bryan@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
While working on an upcoming PR (#377 ) for improving the test coverage, I noticed that the
get_apple_osx_versionmethod has been returningundefined.After further investigation, the RegEx pattern has been looking for OSX SDK version
OS Xno longer exists since Xcode 8+Example print outs:
Xcode 7.3: https://travis-ci.org/erisu/macos-test/jobs/395785417
Xcode 8: https://travis-ci.org/erisu/macos-test/jobs/395785418
For other versions: https://travis-ci.org/erisu/macos-test/builds/395785415
From the above print out, I determined that the RegEx pattern should be updated to
macOSWhat testing has been done on this change?
Note: Oddly Node 4 appears to be failing but I have submitted PR #375 to drop Node 4 support.
Checklist
Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.