spec cover apple version functions (covers GH-376 update) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(was part of apacheGH-377) covers update from apacheGH-376 Co-authored-by: エリス <ellis.bryan@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
brodycj
force-pushed
the
get-apple-version-test
branch
from
d65cc67
to
f3273d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
+ Coverage 63.86% 65.62% +1.76%
==========================================
Files 14 14
Lines 1702 1702
Branches 286 286
==========================================
+ Hits 1087 1117 +30
+ Misses 615 585 -30
Continue to review full report at Codecov.
|
1 task
erisu
added a commit
to erisu/cordova-ios
that referenced
this pull request
Jan 16, 2019
(was part of apacheGH-377) covers update from apacheGH-376 Co-authored-by: エリス <ellis.bryan@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
master(was part of GH-377 by @erisu)
What testing has been done on this change?
npm run unit-testspasses on local machine (also on deprecated Node.js 4 version)npm testitems pass on Travis CI (also on deprecated Node.js 4 version)npm run unit-testspasses on AppVeyor CI (also on deprecated Node.js 4 version)Checklist
Reported an issue in the JIRA databaseCommit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.