Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to readme.md file in npm update output #235

Closed
WuglyakBolgoink opened this issue Oct 2, 2019 · 2 comments · Fixed by #236
Closed

Update link to readme.md file in npm update output #235

WuglyakBolgoink opened this issue Oct 2, 2019 · 2 comments · Fixed by #236
Labels
enhancement

Comments

@WuglyakBolgoink
Copy link

please fix link to readme.md like in cordova-plugin-file
image

what I do:

npm-check -u -E

Link should be https://github.com/apache/cordova-plugin-splashscreen#readme instead of https://cordova.apache.org/
@breautek
Copy link
Contributor

breautek commented Oct 2, 2019

I assume npm-check is reading

cordova-plugin-splashscreen/package.json

Line 50 in be85a1b

"homepage": "https://cordova.apache.org/"

Would welcome a PR.

blackwolf12333 added a commit to blackwolf12333/cordova-plugin-splashscreen that referenced this issue Oct 8, 2019
@blackwolf12333
Fix apache#235: update homepage to github readme page
c2536eb
@blackwolf12333 blackwolf12333 mentioned this issue Oct 8, 2019
Merged
@blackwolf12333
Copy link
Contributor

blackwolf12333 commented Oct 8, 2019 •
edited
Loading

I made a PR :)

You are correct, it looks at the homepage field.

breautek pushed a commit that referenced this issue Jan 12, 2020
@blackwolf12333 @breautek
Fix #235: update homepage to github readme page (#236)
054387e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #235: update homepage to github readme page blackwolf12333/cordova-plugin-splashscreen
3 participants
@blackwolf12333 @WuglyakBolgoink @breautek