Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #235: update homepage to github readme page #236

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

blackwolf12333
Copy link
Contributor

@blackwolf12333 blackwolf12333 commented Oct 8, 2019

Motivation and Context

Fixes #235

Change was requested in issue #235

@breautek
Copy link
Contributor

breautek commented Oct 8, 2019

Please update the Motivation & Context so it contains the keywords "Fixes #235"

e.g.

Motivation and Context
Fixes #235

Change was requested in issue #235

This will help github recognise that once this PR is merged, it will close #235 for automatically.

@blackwolf12333
Copy link
Contributor Author

Oh doesn't that work when you have that in the title of the PR anymore?

@blackwolf12333 blackwolf12333 changed the title Fix #235: update homepage to github readme page Fixes #235: update homepage to github readme page Oct 8, 2019
@breautek
Copy link
Contributor

breautek commented Oct 8, 2019

Oh doesn't that work when you have that in the title of the PR anymore?

Oh sorry you're actually right. I was looking for text on #235 that said that but looks like they moved it to an "i" icon.

@breautek breautek self-requested a review October 8, 2019 13:05
@breautek
Copy link
Contributor

breautek commented Oct 8, 2019

I'm kinda a new member so I don't know what is acceptable for the number of reviewers required, even if the changes are trivial.

@janpio ?

@breautek breautek requested a review from janpio October 8, 2019 13:07
@breautek breautek closed this Jan 12, 2020
@breautek breautek reopened this Jan 12, 2020
@breautek
Copy link
Contributor

Closing/openning to restart travis/appveyor. I believe the error checks were simply caused by a timeout.

@breautek breautek merged commit 054387e into apache:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update link to readme.md file in npm update output
2 participants