build: Re-enable TPCDS q72 for broadcast and hash join configs #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, still seeing the issue in CI. But I cannot reproduce it locally now. |
viirya
changed the title
andygrove
approved these changes
Aug 6, 2024
|
Thanks @andygrove |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…e#781) * build: Re-enable TPCDS q72 * Increase heap size * Move q72 * Skip q72 for sort merge join
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I did memory profiling yesterday again locally, and didn't see the memory issue last time. Trying to re-enable q72.
In Github Action runner, it still cannot run q72 with sort merge join config. I only enabled q72 for other type join configs.
What changes are included in this PR?
How are these changes tested?