EXPLAIN ANALYZE should run all Optimizer passes #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 23, 2021
| LogicalPlan::Analyze { | ||
| verbose, schema, .. | ||
| } => { | ||
| assert!(expr.is_empty()); |
There was a problem hiding this comment.
Here is the actual bug fix: the code that builds up LogicalPlans from optimized inputs ignored the inputs for Analyze. I have a follow on PR to try and make this kind of thing harder to introduce in the future: #930
Dandandan
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #917 found by @Dandandan
Rationale for this change
EXPLAIN ANALYZEshould run the same plan as normal executionWhat changes are included in this PR?
assert_contains!macro in sql.rs (from IOx) to make the testing less repetitiousAre there any user-facing changes?
Bug is fixed