Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [python] Change param user, queue do no work in ProcessDefinition #8751

Closed
3 tasks done
zhongjiajie opened this issue Mar 8, 2022 · 1 comment · Fixed by #9140
Closed
3 tasks done

[Bug] [python] Change param user, queue do no work in ProcessDefinition #8751

zhongjiajie opened this issue Mar 8, 2022 · 1 comment · Fixed by #9140
Assignees
@zhongjiajie
Labels
bug Something isn't working Python

Comments

@zhongjiajie
Copy link
Member

zhongjiajie commented Mar 8, 2022 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When users submit process definition and then change user or queue param in ProcessDefinition object, they could not change workflow attribute

What you expected to happen

ATT

How to reproduce

ATT

Anything else

No response

Version

2.0.5

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@zhongjiajie zhongjiajie added bug Something isn't working Python labels Mar 8, 2022
@zhongjiajie zhongjiajie self-assigned this Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Hi:

@zhongjiajie zhongjiajie added this to the 3.0.0-release milestone Mar 8, 2022
zhongjiajie added a commit to zhongjiajie/dolphinscheduler that referenced this issue Mar 23, 2022
@zhongjiajie
[python] Fix change exists pd attribute user error
32f20f6 
* Remove attribute from class ProcessDefinition, cause it should to
  object User instead of object ProcessDefinition.
* Grant project to user if attribute user change for exists ProcessDefinition

close: apache#8751
zhongjiajie added a commit to zhongjiajie/dolphinscheduler that referenced this issue Mar 23, 2022
@zhongjiajie
[python] Fix change exists pd attribute user error
128ba8b 
* Remove attribute from class ProcessDefinition, cause it should to
  object User instead of object ProcessDefinition.
* Grant project to user if attribute user change for exists ProcessDefinition

close: apache#8751
@zhongjiajie zhongjiajie mentioned this issue Mar 23, 2022
Merged
caishunfeng pushed a commit that referenced this issue Mar 24, 2022
@zhongjiajie
[python] Fix change exists pd attribute user error (#9140)
5289b09 
* [python] Fix change exists pd attribute user error

* Remove attribute from class ProcessDefinition, cause it should to
  object User instead of object ProcessDefinition.
* Grant project to user if attribute user change for exists ProcessDefinition

close: #8751

* Add py.test conftest.py for package integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhongjiajie zhongjiajie

Labels
bug Something isn't working Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[python] Fix change exists pd attribute user error zhongjiajie/dolphinscheduler
1 participant
@zhongjiajie