[python] Fix change exists pd attribute user error #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove attribute from class ProcessDefinition, cause it should to object User instead of object ProcessDefinition. * Grant project to user if attribute user change for exists ProcessDefinition close: apache#8751
Codecov Report
@@ Coverage Diff @@
## dev #9140 +/- ##
=========================================
Coverage 40.27% 40.27%
- Complexity 4363 4365 +2
=========================================
Files 808 808
Lines 32547 32569 +22
Branches 3646 3650 +4
=========================================
+ Hits 13108 13118 +10
- Misses 18210 18220 +10
- Partials 1229 1231 +2
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
|
PTAL @devosend @jieguangzhou thanks. |
caishunfeng
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object User instead of object ProcessDefinition.
close: #8751