Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [dev] version in pom.xml of dev branch confusing #9223

Closed
3 tasks done
EricGao888 opened this issue Mar 27, 2022 · 4 comments · Fixed by #9299
Closed
3 tasks done

[Bug] [dev] version in pom.xml of dev branch confusing #9223

EricGao888 opened this issue Mar 27, 2022 · 4 comments · Fixed by #9299
Assignees
Labels
bug Something isn't working

Comments

@EricGao888
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

  • version in pom.xml of dev branch is confusing. After building the source code, we get apache-dolphinscheduler-2.0.4-SNAPSHOT-xxx.
  • image

What you expected to happen

  • We could change version in pom.xml of dev branch to dev-SNAPSHOT

How to reproduce

  • Build the src code and cd dolphin-scheduler/dolphinscheduler/dolphinscheduler-dist/target, you will see related output stuff all in version 2.0.4-SNAPSHOT.

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@EricGao888 EricGao888 added bug Something isn't working Waiting for reply Waiting for reply labels Mar 27, 2022
@github-actions
Copy link

Hi:

@caishunfeng caishunfeng removed the Waiting for reply Waiting for reply label Mar 27, 2022
@EricGao888
Copy link
Member Author

  • After I switched 2.0.4-SNAPSHOT to dev-SNAPSHOT in all pom.xml files in the project, I recompile the project with cmd mvn -U install package -Prelease -Dmaven.test.skip=true.
  • However, I get some error like org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.2:single (make-assembly) on project dolphinscheduler-data-quality: Failed to create assembly: Error creating assembly archive jar-with-dependencies: Problem creating jar: JAR entry log4j.properties not found in .........../dolphin-scheduler/dolphinscheduler/dolphinscheduler-data-quality/target/archive-tmp/dolphinscheduler-data-quality-dev-SNAPSHOT.jar
  • That's really wired. I didn't changed anything else besides the version number. Any help will be appreciated. @caishunfeng

@caishunfeng
Copy link
Contributor

  • After I switched 2.0.4-SNAPSHOT to dev-SNAPSHOT in all pom.xml files in the project, I recompile the project with cmd mvn -U install package -Prelease -Dmaven.test.skip=true.
  • However, I get some error like org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.2:single (make-assembly) on project dolphinscheduler-data-quality: Failed to create assembly: Error creating assembly archive jar-with-dependencies: Problem creating jar: JAR entry log4j.properties not found in .........../dolphin-scheduler/dolphinscheduler/dolphinscheduler-data-quality/target/archive-tmp/dolphinscheduler-data-quality-dev-SNAPSHOT.jar
  • That's really wired. I didn't changed anything else besides the version number. Any help will be appreciated. @caishunfeng

@EricGao888 can you submit a pr? and then I will have a try at local

@EricGao888
Copy link
Member Author

  • After I switched 2.0.4-SNAPSHOT to dev-SNAPSHOT in all pom.xml files in the project, I recompile the project with cmd mvn -U install package -Prelease -Dmaven.test.skip=true.
  • However, I get some error like org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.2:single (make-assembly) on project dolphinscheduler-data-quality: Failed to create assembly: Error creating assembly archive jar-with-dependencies: Problem creating jar: JAR entry log4j.properties not found in .........../dolphin-scheduler/dolphinscheduler/dolphinscheduler-data-quality/target/archive-tmp/dolphinscheduler-data-quality-dev-SNAPSHOT.jar
  • That's really wired. I didn't changed anything else besides the version number. Any help will be appreciated. @caishunfeng

@EricGao888 can you submit a pr? and then I will have a try at local

I've submitted the PR, not sure where I got things wrong, lol. @caishunfeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants