Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Bug][Dev]Switch version in pom.xml to dev-SNAPSHOT (#9223) #9248

Closed
wants to merge 0 commits into from

Conversation

EricGao888
Copy link
Member

Purpose of the pull request

Brief change log

  • As stated above in Purpose section.

Verify this pull request

  • Compile the code with cmd mvn -U install package -Prelease -Dmaven.test.skip=true and related output jars/packages should be of version dev-SNAPSHOT

@codecov-commenter
Copy link

Codecov Report

Merging #9248 (5456e84) into dev (e00727c) will decrease coverage by 0.11%.
The diff coverage is 21.95%.

❗ Current head 5456e84 differs from pull request most recent head 3f4f9df. Consider uploading reports for the commit 3f4f9df to get more accurate results

@@             Coverage Diff              @@
##                dev    #9248      +/-   ##
============================================
- Coverage     40.21%   40.09%   -0.12%     
+ Complexity     4375     4374       -1     
============================================
  Files           817      820       +3     
  Lines         32676    32743      +67     
  Branches       3637     3640       +3     
============================================
- Hits          13140    13129      -11     
- Misses        18306    18387      +81     
+ Partials       1230     1227       -3     
Impacted Files Coverage Δ
...uler/plugin/alert/wechat/WeChatAlertConstants.java 0.00% <0.00%> (ø)
...lugin/alert/wechat/WeChatAlertParamsConstants.java 0.00% <ø> (ø)
...uler/plugin/alert/wechat/WechatAppChatMessage.java 0.00% <0.00%> (ø)
...cheduler/plugin/alert/wechat/WechatAppMessage.java 0.00% <0.00%> (ø)
...che/dolphinscheduler/api/ApiApplicationServer.java 33.33% <ø> (-26.67%) ⬇️
.../dolphinscheduler/common/enums/SlotCheckState.java 0.00% <0.00%> (ø)
...java/org/apache/dolphinscheduler/dao/AlertDao.java 21.73% <0.00%> (-0.74%) ⬇️
...pache/dolphinscheduler/dao/entity/ProjectUser.java 65.51% <0.00%> (-7.56%) ⬇️
.../datasource/api/client/CommonDataSourceClient.java 0.00% <ø> (ø)
...ugin/datasource/oracle/OracleDataSourceClient.java 0.00% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00727c...3f4f9df. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@EricGao888
Copy link
Member Author

Please do not merge this PR at this time. There's still something wrong with it.

@zhongjiajie zhongjiajie self-requested a review March 29, 2022 07:49
@zhongjiajie
Copy link
Member

Please do not merge this PR at this time. There's still something wrong with it.

Is there still WIP for this PR?

@EricGao888
Copy link
Member Author

Please do not merge this PR at this time. There's still something wrong with it.

Is there still WIP for this PR?

Still WIP, some wired issue with log4j.properties. #9223 (comment)

@zhongjiajie
Copy link
Member

I will test locally in my laptop to try this PR,

@zhongjiajie
Copy link
Member

@EricGao888 I find out your PR does not change anything. Did you delete your branch? Fix-9223

@EricGao888
Copy link
Member Author

@EricGao888 I find out your PR does not change anything. Did you delete your branch? Fix-9223

@zhongjiajie Sorry I mistakenly delete the branch last night. I will recover it later.

@EricGao888
Copy link
Member Author

@EricGao888 I find out your PR does not change anything. Did you delete your branch? Fix-9223

@zhongjiajie Sorry I mistakenly delete the branch last night. I will recover it later.

I reopened the PR here: #9299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [dev] version in pom.xml of dev branch confusing
3 participants