Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][master] Optimize failover #9263

Closed
3 tasks done
huagetai opened this issue Mar 29, 2022 · 1 comment · Fixed by #9281
Closed
3 tasks done

[Improvement][master] Optimize failover #9263

huagetai opened this issue Mar 29, 2022 · 1 comment · Fixed by #9281
Assignees
Labels
feature new feature

Comments

@huagetai
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Now Master server failover is mainly implemented by MasterRegistryClient and FailoverExecuteThread。Consider whether the failover code can be isolated。
This makes the responsibilities clearer:
MasterRegistryClient--Responsible for node registration、state listener、 removing dead server
FailoverExecuteThread--Responsible for executing failover
FailoverService--Responsible for failover

Use case

The function of the refactored class is clearer

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@huagetai huagetai added feature new feature Waiting for reply Waiting for reply labels Mar 29, 2022
@github-actions
Copy link

Hi:

@caishunfeng caishunfeng removed the Waiting for reply Waiting for reply label Mar 29, 2022
huagetai added a commit to huagetai/dolphinscheduler that referenced this issue Mar 30, 2022
- add FailoverService.java
- move failover method  from MasterRegistryClient to FailoverService
- move failover code from FailoverExecuteThread to FailoverService

This closes apache#9263
caishunfeng pushed a commit that referenced this issue Apr 12, 2022
- add FailoverService.java
- move failover method  from MasterRegistryClient to FailoverService
- move failover code from FailoverExecuteThread to FailoverService

This closes #9263
Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this issue Jun 16, 2022
- add FailoverService.java
- move failover method  from MasterRegistryClient to FailoverService
- move failover code from FailoverExecuteThread to FailoverService

This closes apache#9263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants