-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement-9263][master]Implement optimize failover #9281
Conversation
- add FailoverService.java - move failover method from MasterRegistryClient to FailoverService - move failover code from FailoverExecuteThread to FailoverService This closes apache#9263
Codecov Report
@@ Coverage Diff @@
## dev #9281 +/- ##
============================================
+ Coverage 40.08% 40.33% +0.24%
- Complexity 4372 4393 +21
============================================
Files 820 821 +1
Lines 32744 32779 +35
Branches 3640 3646 +6
============================================
+ Hits 13125 13220 +95
+ Misses 18390 18318 -72
- Partials 1229 1241 +12
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! |
...r/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- add FailoverService.java - move failover method from MasterRegistryClient to FailoverService - move failover code from FailoverExecuteThread to FailoverService This closes apache#9263
Purpose of the pull request
Implement optimize failover
Brief changelog
This closes #9263
Verify this pull request
This change added tests and can be verified as follows: