Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-9263][master]Implement optimize failover #9281

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

huagetai
Copy link
Contributor

Purpose of the pull request

Implement optimize failover

Brief changelog

  • add FailoverService.java
  • move the failover method from MasterRegistryClient to FailoverService
  • move failover code from FailoverExecuteThread to FailoverService

This closes #9263

Verify this pull request

This change added tests and can be verified as follows:

  • Added FailoverServiceTest for FailoverService.
  • Manually verified the change by testing locally.

- add FailoverService.java
- move failover method  from MasterRegistryClient to FailoverService
- move failover code from FailoverExecuteThread to FailoverService

This closes apache#9263
@codecov-commenter
Copy link

Codecov Report

Merging #9281 (bdca52c) into dev (11d9859) will increase coverage by 0.24%.
The diff coverage is 62.66%.

@@             Coverage Diff              @@
##                dev    #9281      +/-   ##
============================================
+ Coverage     40.08%   40.33%   +0.24%     
- Complexity     4372     4393      +21     
============================================
  Files           820      821       +1     
  Lines         32744    32779      +35     
  Branches       3640     3646       +6     
============================================
+ Hits          13125    13220      +95     
+ Misses        18390    18318      -72     
- Partials       1229     1241      +12     
Impacted Files Coverage Δ
...er/server/master/runner/FailoverExecuteThread.java 0.00% <0.00%> (ø)
...r/server/master/registry/MasterRegistryClient.java 48.42% <50.00%> (+9.33%) ⬆️
...heduler/server/master/service/FailoverService.java 63.44% <63.44%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...er/server/master/runner/WorkflowExecuteThread.java 8.27% <0.00%> (-0.12%) ⬇️
...lphinscheduler/service/process/ProcessService.java 30.33% <0.00%> (-0.05%) ⬇️
...server/master/runner/task/CommonTaskProcessor.java 4.54% <0.00%> (+0.06%) ⬆️
...erver/master/runner/WorkflowExecuteThreadPool.java 1.42% <0.00%> (+1.42%) ⬆️
...er/server/master/runner/task/SubTaskProcessor.java 47.52% <0.00%> (+41.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d9859...bdca52c. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

73.9% 73.9% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng requested a review from lenboo April 10, 2022 07:17
@caishunfeng caishunfeng merged commit 6992354 into apache:dev Apr 12, 2022
Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022
- add FailoverService.java
- move failover method  from MasterRegistryClient to FailoverService
- move failover code from FailoverExecuteThread to FailoverService

This closes apache#9263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][master] Optimize failover
3 participants