Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retry when connecting to mysql for task information #9458

Closed
wants to merge 1 commit into from

Conversation

bigdatazhao
Copy link

Purpose of the pull request

Added retries to get task information in mysql

Verify this pull request

Manually verified the change by testing locally

@SbloodyS SbloodyS added the first time contributor First-time contributor label Apr 12, 2022
@SbloodyS
Copy link
Member

SbloodyS commented Apr 12, 2022

Hi @bigdatazhao ,thank you for your contribution. Can you open an issue link to this pr to describe why did you want to do that?

@zhongjiajie
Copy link
Member

zhongjiajie commented Apr 21, 2022

I do not think we should add retry in this function, each function query database could have the same issue, maybe we should add in meta database connection. Am I right @caishunfeng

@caishunfeng
Copy link
Contributor

Hi @bigdatazhao There is the same logic implement by FailoverExecuteThread, so it's no need to add retry logic into failoverMaster.
BTW, the latest dev code use the FailoverService to unified failover logic, see #9281

I will close this pr, but thanks for your submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend discussion discussion first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants