[improve] Optimize MLFlow task plugin for easy of use #12071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
requested review from
zhongjiajie,
Tianqi-Dotes,
EricGao888,
songjianet,
Amy0104,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
jieguangzhou
changed the title
jieguangzhou
force-pushed
the
mlflow-repo-config
branch
from
4314b62
to
82b9001
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowTask.java
Fixed
Show fixed
Hide fixed
...ler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowTask.java
Fixed
Show fixed
Hide fixed
jieguangzhou
force-pushed
the
mlflow-repo-config
branch
from
82b9001
to
191af8e
Compare
...ler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowTask.java
Fixed
Show fixed
Hide fixed
...ler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowTask.java
Fixed
Show fixed
Hide fixed
optimize code
jieguangzhou
force-pushed
the
mlflow-repo-config
branch
from
b194fd1
to
d94b757
Compare
EricGao888
reviewed
Sep 21, 2022
...duler-task-mlflow/src/test/java/org/apache/dolphinler/plugin/task/mlflow/MlflowTaskTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #12071 +/- ##
============================================
- Coverage 38.65% 38.55% -0.11%
- Complexity 4005 4007 +2
============================================
Files 1002 1004 +2
Lines 37213 37390 +177
Branches 4249 4263 +14
============================================
+ Hits 14386 14415 +29
- Misses 21195 21329 +134
- Partials 1632 1646 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
approved these changes
Sep 21, 2022
zhongjiajie
changed the title
jieguangzhou
added a commit
to jieguangzhou/dolphinscheduler
that referenced
this pull request
Sep 21, 2022
optimize code (cherry picked from commit cf522e2)
zhongjiajie
pushed a commit
that referenced
this pull request
Sep 21, 2022
optimize code (cherry picked from commit cf522e2)
caishunfeng
added
the
release cherry-pick
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close: #12070
dolphinscheduler-mlflowrepositoryWe can modify the repository address to the local path if we can not access git
docker compose, keep deploy withDockerdocker composeandDOCKERof MLflow models are highly similar, keep the delicate oneBrief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)