-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-13428][Resource Center] Add support for Google Cloud Storage in the resource center #13562
Conversation
9d551e8
to
35cb2ff
Compare
Codecov Report
@@ Coverage Diff @@
## dev #13562 +/- ##
============================================
- Coverage 39.47% 39.43% -0.05%
- Complexity 4382 4401 +19
============================================
Files 1102 1104 +2
Lines 41437 41675 +238
Branches 4733 4754 +21
============================================
+ Hits 16359 16436 +77
- Misses 23262 23413 +151
- Partials 1816 1826 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
35cb2ff
to
8ff539f
Compare
dd15daf
to
649ebaf
Compare
… in the resource center
649ebaf
to
a5a00e2
Compare
SonarCloud Quality Gate failed. |
Hi, @zhongjiajie , @SbloodyS , @EricGao888 ,could you please help review this? |
} | ||
|
||
@Override | ||
public boolean delete(String filePath, boolean recursive) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the parameter recursive
not use in this method, so GCS does not support delete recursive in this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @zhongjiajie , thanks a lot for your kind review. Perhaps for some historical reasons, recursive
is not used (also in the S3StorageOperator
and OssStorageOperator
).
Another interface below is called when deleting with a childrenPathList
.
@Override
public boolean delete(String fullName, List<String> childrenPathList, boolean recursive) throws IOException {
// append the resource fullName to the list for deletion.
childrenPathList.add(fullName);
boolean result = true;
for (String filePath : childrenPathList) {
if (!delete(filePath, recursive)) {
result = false;
}
}
return result;
}
… in the resource center (apache#13562)
Purpose of the pull request
Brief change log
Verify this pull request
UT and manually tested
common.properties