Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-13989] Add path validation #14021

Merged
merged 7 commits into from
May 6, 2023
Merged

[Fix-13989] Add path validation #14021

merged 7 commits into from
May 6, 2023

Conversation

ly109974
Copy link
Contributor

@ly109974 ly109974 commented Apr 26, 2023

fix #13989

@SbloodyS SbloodyS requested a review from zhongjiajie April 27, 2023 06:05
@SbloodyS SbloodyS added bug Something isn't working backend 3.2.0 for 3.2.0 version labels Apr 27, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Apr 27, 2023
@SbloodyS SbloodyS changed the title add path validation [Fix-13989] Add path validation Apr 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #14021 (0cf6870) into dev (d2f83ee) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 0cf6870 differs from pull request most recent head 265cc18. Consider uploading reports for the commit 265cc18 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14021   +/-   ##
=========================================
  Coverage     38.24%   38.25%           
+ Complexity     4444     4443    -1     
=========================================
  Files          1222     1222           
  Lines         42759    42762    +3     
  Branches       4744     4745    +1     
=========================================
+ Hits          16352    16357    +5     
+ Misses        24598    24596    -2     
  Partials       1809     1809           
Impacted Files Coverage Δ
...duler/plugin/storage/hdfs/HdfsStorageOperator.java 19.45% <0.00%> (-0.21%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhongjiajie
Copy link
Member

zhongjiajie commented Apr 28, 2023

Thanks for fixing so fast, and I see you only fix HDFS storage operatior, did you test wether other operator like gcs, oss and s3 work or not? @ly109974

@rickchengx
Copy link
Contributor

Thanks for fixing so fast, and I see you only fix HDFS storage operatior, did you test wether other operator like gcs, oss and s3 work or not? @ly109974

Hi, @zhongjiajie the listFilesStatus() in GCS / OSS works well, which has been tested in

@ly109974 ly109974 closed this Apr 28, 2023
@ly109974
Copy link
Contributor Author

ly109974 commented Apr 28, 2023

Thanks for fixing so fast, and I see you only fix HDFS storage operatior, did you test wether other operator like gcs, oss and s3 work or not? @ly109974

I don't have an environment, is there any other way? @zhongjiajie

@ly109974 ly109974 reopened this Apr 28, 2023
@github-actions github-actions bot removed the backend label Apr 28, 2023
@ly109974 ly109974 reopened this May 5, 2023
@zhongjiajie
Copy link
Member

approval the ci run

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie merged commit f269ccb into apache:dev May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [resource] resource center
5 participants