[bug] Fix datax task type error parse clickhouse reader sql #8091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongjiajie
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #8091 +/- ##
============================================
- Coverage 41.50% 41.49% -0.01%
- Complexity 3731 3756 +25
============================================
Files 637 637
Lines 27118 27221 +103
Branches 3074 3131 +57
============================================
+ Hits 11254 11295 +41
- Misses 14784 14831 +47
- Partials 1080 1095 +15
Continue to review full report at Codecov.
|
zhongjiajie
reviewed
Jan 18, 2022
...duler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxUtils.java
Outdated
Show resolved
Hide resolved
zhongjiajie
changed the title
|
I think is good and could be merged. WDYT @zhuangchong |
|
Kudos, SonarCloud Quality Gate passed! |
|
@seagle-yuan |
yimaixinchen
pushed a commit
to yimaixinchen/dolphinscheduler
that referenced
this pull request
Jan 19, 2022
brave-lee
pushed a commit
to brave-lee/dolphinscheduler
that referenced
this pull request
Feb 18, 2022
brave-lee
added a commit
that referenced
this pull request
Feb 18, 2022
* fix relation unbinding bug * [Bug-8053] Fix CronUtils.getMaxCycle return null (#8086) * [bug] Fix datax task type error parse clickhouse reader sql (#8091) * [Fix-8119][API] Update ProcessInstance error and without reason output (#8122) * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * pick-8086/8091/8122/8139 * [Bug-8169] [dolphinscheduler-ui] Fix `After you save the workflow, it… (#8198) * [Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. (#8359) * add reupload file * develop reupload file * fix this issue * [Improvement-8284][Alert] Dingtalk alert plugin supports markdown message type (#8285) * add msgtype in the dingtalk alert plugin * update markdown msgtype 'at persion' * fix sudo.enable=false Is invalid (#8388) * [Fix][UI] Rectify this issue with missing the re-uploading file button when the file is under the root directory. Co-authored-by: springmonster <charleskuanghc@163.com> Co-authored-by: seagle <seagle-yuan@users.noreply.github.com> Co-authored-by: xiangzihao <460888207@qq.com> Co-authored-by: Kerwin <37063904+zhuangchong@users.noreply.github.com> Co-authored-by: calvin <jianghuachinacom@163.com> Co-authored-by: ShuiMuNianHuaLP <46993277+ShuiMuNianHuaLP@users.noreply.github.com>
caishunfeng
pushed a commit
that referenced
this pull request
Feb 21, 2022
… binding api (#8466) * fix relation unbinding bug * [Bug-8053] Fix CronUtils.getMaxCycle return null (#8086) * [bug] Fix datax task type error parse clickhouse reader sql (#8091) * [Fix-8119][API] Update ProcessInstance error and without reason output (#8122) * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * pick-8086/8091/8122/8139 * [Bug-8169] [dolphinscheduler-ui] Fix `After you save the workflow, it… (#8198) * [Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. (#8359) * add reupload file * develop reupload file * fix this issue * [Improvement-8284][Alert] Dingtalk alert plugin supports markdown message type (#8285) * add msgtype in the dingtalk alert plugin * update markdown msgtype 'at persion' * fix sudo.enable=false Is invalid (#8388) * [Fix][UI] Rectify this issue with missing the re-uploading file button when the file is under the root directory. * [Bug] [API] fix releaseWorkflowAndSchedule api and relation binding api (#8464) * fix relation unbinding bug * fix 8463 Co-authored-by: springmonster <charleskuanghc@163.com> Co-authored-by: seagle <seagle-yuan@users.noreply.github.com> Co-authored-by: xiangzihao <460888207@qq.com> Co-authored-by: Kerwin <37063904+zhuangchong@users.noreply.github.com> Co-authored-by: calvin <jianghuachinacom@163.com> Co-authored-by: ShuiMuNianHuaLP <46993277+ShuiMuNianHuaLP@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
this pr close #8092
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: