Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. #8359

Merged
merged 3 commits into from
Feb 13, 2022

Conversation

calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #8187 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.
    When the type of resource is file, you can re-upload a file to replace the file.
    image

image

@codecov-commenter
Copy link

Codecov Report

Merging #8359 (b6c6f04) into dev (91b91c9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #8359   +/-   ##
=========================================
  Coverage     45.29%   45.29%           
- Complexity     3993     3994    +1     
=========================================
  Files           680      680           
  Lines         26456    26456           
  Branches       2848     2848           
=========================================
+ Hits          11983    11984    +1     
  Misses        13339    13339           
+ Partials       1134     1133    -1     
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 83.60% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b91c9...b6c6f04. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@songjianet songjianet added this to the 2.0.4-release milestone Feb 13, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Feb 13, 2022
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 3f6caef into apache:dev Feb 13, 2022
brave-lee pushed a commit to brave-lee/dolphinscheduler that referenced this pull request Feb 18, 2022
…n re-upload the file on the page of the file management. (apache#8359)

* add reupload file

* develop reupload file

* fix this issue
brave-lee added a commit that referenced this pull request Feb 18, 2022
* fix relation unbinding bug

* [Bug-8053] Fix CronUtils.getMaxCycle return null (#8086)

* [bug] Fix datax task type error parse clickhouse reader sql (#8091)

* [Fix-8119][API] Update ProcessInstance error and without reason output (#8122)

* fix bug_8119

* fix bug_8119

* fix bug_8119

* fix bug_8119

* fix bug_8119

* pick-8086/8091/8122/8139

* [Bug-8169] [dolphinscheduler-ui] Fix `After you save the workflow, it… (#8198)

* [Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. (#8359)

* add reupload file

* develop reupload file

* fix this issue

* [Improvement-8284][Alert] Dingtalk alert plugin supports markdown message type (#8285)

* add msgtype in the dingtalk alert plugin

* update markdown msgtype 'at persion'

* fix sudo.enable=false Is invalid (#8388)

* [Fix][UI] Rectify this issue with missing the re-uploading file button when the file is under the root directory.

Co-authored-by: springmonster <charleskuanghc@163.com>
Co-authored-by: seagle <seagle-yuan@users.noreply.github.com>
Co-authored-by: xiangzihao <460888207@qq.com>
Co-authored-by: Kerwin <37063904+zhuangchong@users.noreply.github.com>
Co-authored-by: calvin <jianghuachinacom@163.com>
Co-authored-by: ShuiMuNianHuaLP <46993277+ShuiMuNianHuaLP@users.noreply.github.com>
caishunfeng pushed a commit that referenced this pull request Feb 21, 2022
… binding api (#8466)

* fix relation unbinding bug

* [Bug-8053] Fix CronUtils.getMaxCycle return null (#8086)

* [bug] Fix datax task type error parse clickhouse reader sql (#8091)

* [Fix-8119][API] Update ProcessInstance error and without reason output (#8122)

* fix bug_8119

* fix bug_8119

* fix bug_8119

* fix bug_8119

* fix bug_8119

* pick-8086/8091/8122/8139

* [Bug-8169] [dolphinscheduler-ui] Fix `After you save the workflow, it… (#8198)

* [Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. (#8359)

* add reupload file

* develop reupload file

* fix this issue

* [Improvement-8284][Alert] Dingtalk alert plugin supports markdown message type (#8285)

* add msgtype in the dingtalk alert plugin

* update markdown msgtype 'at persion'

* fix sudo.enable=false Is invalid (#8388)

* [Fix][UI] Rectify this issue with missing the re-uploading file button when the file is under the root directory.

* [Bug] [API] fix releaseWorkflowAndSchedule api and relation binding api (#8464)

* fix relation unbinding bug

* fix 8463

Co-authored-by: springmonster <charleskuanghc@163.com>
Co-authored-by: seagle <seagle-yuan@users.noreply.github.com>
Co-authored-by: xiangzihao <460888207@qq.com>
Co-authored-by: Kerwin <37063904+zhuangchong@users.noreply.github.com>
Co-authored-by: calvin <jianghuachinacom@163.com>
Co-authored-by: ShuiMuNianHuaLP <46993277+ShuiMuNianHuaLP@users.noreply.github.com>
@zhongjiajie zhongjiajie added the miss:docs missing documents in PR label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working miss:docs missing documents in PR UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [resource] Whether the re-upload function can be retained
4 participants