-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. #8359
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #8359 +/- ##
=========================================
Coverage 45.29% 45.29%
- Complexity 3993 3994 +1
=========================================
Files 680 680
Lines 26456 26456
Branches 2848 2848
=========================================
+ Hits 11983 11984 +1
Misses 13339 13339
+ Partials 1134 1133 -1
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n re-upload the file on the page of the file management. (apache#8359) * add reupload file * develop reupload file * fix this issue
* fix relation unbinding bug * [Bug-8053] Fix CronUtils.getMaxCycle return null (#8086) * [bug] Fix datax task type error parse clickhouse reader sql (#8091) * [Fix-8119][API] Update ProcessInstance error and without reason output (#8122) * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * pick-8086/8091/8122/8139 * [Bug-8169] [dolphinscheduler-ui] Fix `After you save the workflow, it… (#8198) * [Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. (#8359) * add reupload file * develop reupload file * fix this issue * [Improvement-8284][Alert] Dingtalk alert plugin supports markdown message type (#8285) * add msgtype in the dingtalk alert plugin * update markdown msgtype 'at persion' * fix sudo.enable=false Is invalid (#8388) * [Fix][UI] Rectify this issue with missing the re-uploading file button when the file is under the root directory. Co-authored-by: springmonster <charleskuanghc@163.com> Co-authored-by: seagle <seagle-yuan@users.noreply.github.com> Co-authored-by: xiangzihao <460888207@qq.com> Co-authored-by: Kerwin <37063904+zhuangchong@users.noreply.github.com> Co-authored-by: calvin <jianghuachinacom@163.com> Co-authored-by: ShuiMuNianHuaLP <46993277+ShuiMuNianHuaLP@users.noreply.github.com>
… binding api (#8466) * fix relation unbinding bug * [Bug-8053] Fix CronUtils.getMaxCycle return null (#8086) * [bug] Fix datax task type error parse clickhouse reader sql (#8091) * [Fix-8119][API] Update ProcessInstance error and without reason output (#8122) * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * fix bug_8119 * pick-8086/8091/8122/8139 * [Bug-8169] [dolphinscheduler-ui] Fix `After you save the workflow, it… (#8198) * [Fix-8187][UI] Add the function to the module of resource that you can re-upload the file on the page of the file management. (#8359) * add reupload file * develop reupload file * fix this issue * [Improvement-8284][Alert] Dingtalk alert plugin supports markdown message type (#8285) * add msgtype in the dingtalk alert plugin * update markdown msgtype 'at persion' * fix sudo.enable=false Is invalid (#8388) * [Fix][UI] Rectify this issue with missing the re-uploading file button when the file is under the root directory. * [Bug] [API] fix releaseWorkflowAndSchedule api and relation binding api (#8464) * fix relation unbinding bug * fix 8463 Co-authored-by: springmonster <charleskuanghc@163.com> Co-authored-by: seagle <seagle-yuan@users.noreply.github.com> Co-authored-by: xiangzihao <460888207@qq.com> Co-authored-by: Kerwin <37063904+zhuangchong@users.noreply.github.com> Co-authored-by: calvin <jianghuachinacom@163.com> Co-authored-by: ShuiMuNianHuaLP <46993277+ShuiMuNianHuaLP@users.noreply.github.com>
hi @calvinjiang I see we have a new functional added here. We should better add doc in repo https://github.com/apache/dolphinscheduler-website . The detail page in https://github.com/apache/dolphinscheduler-website/blob/master/docs/en-us/dev/user_doc/guide/resource.md and https://github.com/apache/dolphinscheduler-website/blob/master/docs/zh-cn/dev/user_doc/guide/resource.md Thanks |
Purpose of the pull request
This PR will close #8187 .
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
When the type of resource is file, you can re-upload a file to replace the file.