Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI][V1.0.0-Beta] Remove the sql comment in the procedure task and add the instructions link to the procedure task. #9619

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

Amy0104
Copy link
Member

@Amy0104 Amy0104 commented Apr 20, 2022

Purpose of the pull request

This pull request removes the sql comment in the procedure task and adds the instructions link to the procedure task.

Related issues

close #9613

…nd add the instructions link to the procedure task.
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Apr 20, 2022
@songjianet songjianet added this to the 3.0.0-beta milestone Apr 20, 2022
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #9619 (460242c) into dev (9d11be4) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9619      +/-   ##
============================================
- Coverage     39.96%   39.91%   -0.05%     
  Complexity     4437     4437              
============================================
  Files           832      833       +1     
  Lines         33351    33391      +40     
  Branches       3683     3685       +2     
============================================
  Hits          13328    13328              
- Misses        18792    18832      +40     
  Partials       1231     1231              
Impacted Files Coverage Δ
...er/api/controller/ProcessDefinitionController.java 45.34% <0.00%> (-2.22%) ⬇️
...api/service/impl/ProcessDefinitionServiceImpl.java 31.07% <0.00%> (-0.67%) ⬇️
...cheduler/api/service/impl/ExecutorServiceImpl.java 40.62% <0.00%> (-0.26%) ⬇️
...eduler/dao/entity/DependentSimplifyDefinition.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d11be4...460242c. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@songjianet songjianet merged commit 69bfebf into apache:dev Apr 20, 2022
fengjian1129 pushed a commit to fengjian1129/dolphinscheduler that referenced this pull request Apr 23, 2022
…nd add the instructions link to the procedure task. (apache#9619)
@Amy0104 Amy0104 deleted the fix-9613 branch June 27, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG-FE][PROCEDURE Component][V1.0.0-Beta] PROCEDUREComponent is running with errors
4 participants